Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update release policy #5749

Merged
merged 1 commit into from
Apr 1, 2020

Conversation

Miouge1
Copy link
Contributor

@Miouge1 Miouge1 commented Mar 10, 2020

What type of PR is this?
/kind documentation

What this PR does / why we need it:
Adding info about kube_version_min_required and checksums.

@k8s-ci-robot k8s-ci-robot added kind/documentation Categorizes issue or PR as related to documentation. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 10, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Miouge1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 10, 2020
@k8s-ci-robot k8s-ci-robot requested review from ant31 and chadswen March 10, 2020 13:35
@mattymo
Copy link
Contributor

mattymo commented Mar 10, 2020

+1 from me. Waiting for others to review

@LuckySB
Copy link
Contributor

LuckySB commented Mar 10, 2020

+1
I support if the practice of removing version hashes only after eol - is accepted.

And I understand that this is more likely a gentleman's agreement ;)
and in this document it should not be indicated

@EppO
Copy link
Contributor

EppO commented Mar 10, 2020

  • Minor releases can change components' versions, but not the major kube_version.

If I understand correctly, it means that kubespray will only support Kubernetes 1.17 in 3.x?

@Miouge1
Copy link
Contributor Author

Miouge1 commented Mar 11, 2020

@EppO Line 21/22 it says Fixes for major releases (vX.Y), therefore Kubespray v2.13 is the next major release, and it will support only v1.17.

It can be a little confusing if you are used to semver.

@huxcrux
Copy link

huxcrux commented Mar 11, 2020

Looks good 👍

Copy link
Member

@chadswen chadswen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, seems sensible and clear.

Related sidenote, I can start a new issue if there's interest: I once had an idea to support incremental kubernetes version upgrades automatically from upgrade-cluster.yml (e.g. when upgrading a kube_version: v1.13 cluster to v1.15 the playbook handles the required v1.14 upgrade for the user before applying the v1.15 upgrade). Slack thread

However, we should only consider that if the community thinks the convenience of running the upgrade playbook just once to upgrade across multiple k8s feature releases is worth the added complexity and effort. Otherwise, this current approach works quite well.

@Miouge1 Miouge1 added this to the 2.13 milestone Apr 1, 2020
@Atoms
Copy link
Member

Atoms commented Apr 1, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 1, 2020
@k8s-ci-robot k8s-ci-robot merged commit c72903e into kubernetes-sigs:master Apr 1, 2020
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Apr 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants