Skip coredns phase when initializing other uninitialized masters #4867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/XS
|
ci check this |
woopstar
changed the title
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: liuxu623, woopstar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
holmsten
pushed a commit
to holmsten/kubespray
that referenced
this pull request
Jun 13, 2019
k8s-ci-robot
pushed a commit
that referenced
this pull request
Jun 13, 2019
LuckySB
pushed a commit
to southbridgeio/kubespray
that referenced
this pull request
Aug 4, 2019
VannTen
added a commit
to VannTen/kubespray
that referenced
this pull request
Dec 6, 2023
Kubeadm dns phase is correctly skipped. This was a workaround for kubernetes/kubeadm#1557, which was actually not a bug ; the correct fix was kubernetes-sigs#4867
k8s-ci-robot
pushed a commit
that referenced
this pull request
Dec 7, 2023
Kubeadm dns phase is correctly skipped. This was a workaround for kubernetes/kubeadm#1557, which was actually not a bug ; the correct fix was #4867
pedro-peter
pushed a commit
to pedro-peter/kubespray
that referenced
this pull request
May 8, 2024
…10695) Kubeadm dns phase is correctly skipped. This was a workaround for kubernetes/kubeadm#1557, which was actually not a bug ; the correct fix was kubernetes-sigs#4867
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: