Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update probe timeouts, delays etc. #4612

Merged
merged 3 commits into from
Apr 23, 2019

Conversation

woopstar
Copy link
Member

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
Fix delays and timeouts

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 23, 2019
@woopstar
Copy link
Member Author

ci check this

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: woopstar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 23, 2019
@Miouge1
Copy link
Contributor

Miouge1 commented Apr 23, 2019

Looks good, we might need to trigger a couple of manual CI jobs to cover this with tests properly.

@Miouge1
Copy link
Contributor

Miouge1 commented Apr 23, 2019

Looks OK if CI is happy.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 23, 2019
@k8s-ci-robot k8s-ci-robot merged commit d588532 into kubernetes-sigs:master Apr 23, 2019
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request May 5, 2019
* Fix merge conflict

* Add check delay

* Add more liveness and readiness options to metrics-server
unbreakab1e pushed a commit to joomcode/kubespray that referenced this pull request Jun 5, 2019
* Fix merge conflict

* Add check delay

* Add more liveness and readiness options to metrics-server
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants