flannel: set EnableNFTables when kube_proxy_mode use nftables#13291
flannel: set EnableNFTables when kube_proxy_mode use nftables#13291rtsui-harmonicinc wants to merge 1 commit into
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: rtsui-harmonicinc The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @rtsui-harmonicinc. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds flannel configuration toggles/comments to align with newer flannel releases (nftables support and an optional cache-readiness env var).
Changes:
- Add
EnableNFTablesto flannelnet-conf.json, derived fromkube_proxy_mode. - Add commented documentation for
CONT_WHEN_CACHE_NOT_READY(introduced in flannel v0.27.1).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "EnableIPv6": true, | ||
| "IPv6Network": "{{ kube_pods_subnet_ipv6 }}", | ||
| {% endif %} | ||
| "EnableNFTables": {{ (kube_proxy_mode == 'nftables') | bool | to_json }}, |
| # CONT_WHEN_CACHE_NOT_READY added in flannel v0.27.1 | ||
| # - name: CONT_WHEN_CACHE_NOT_READY | ||
| # value: "false" |
|
/ok-to-test |
What type of PR is this?
What this PR does / why we need it:
Testing RL10 deployment using flannel showed an issue.
Since iptables is no longer included in RL10. iptables mode kube-proxy would enter crash-loop and fail to start. However, iptables is still being used even when kube-proxy is set to nftables mode.
The iptables-nft shim is not capable for flannel needs.
Ansible Log:
kube-proxy log(when using iptables mode on RL10):
Log(when using nft mode but EnableNFTables not specified):
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: