Replace injected Ansible fact variables in bootstrap_os role

[NikKumar811]

What type of PR is this?

/kind cleanup

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:

This PR updates the bootstrap_os role to replace usage of injected Ansible fact variables (ansible_*) with ansible_facts[...]. This ensures compatibility with upcoming Ansible 2.24 changes, where fact injection will be disabled by default.

Which issue(s) this PR fixes:

Related to #13208

Special notes for your reviewer:

• Changes are limited to the bootstrap_os role for focused review
• No changes were made to hostvars, ansible_env, or set_fact usage
• Existing logic and behavior are preserved
• Roles reviewed with no required changes:
  - adduser
  - bastion-ssh-config
  - bootstrap-os

Does this PR introduce a user-facing change?:

None

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: NikKumar811
Once this PR has been reviewed and has the lgtm label, please assign tico88612 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

Hi @NikKumar811. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[tico88612]

/ok-to-test

[yankay]

Nit: rest of the repo uses ansible_*-prefixed patterns for setup's filter (e.g. roles/bootstrap_os/tasks/main.yml, playbooks/internal_facts.yml). Could we keep the prefix for consistency? Same for rhel.yml / opensuse.yml.

[NikKumar811]

Yes, right, I updated the remaining setup filters in centos.yml and rhel.yml back to the existing ansible_* pattern used elsewhere in the repo.

[yankay]

The setup task here is stale — it was added in #9175 to support python-cryptography install conditionals that have since been moved to system_packages (d5b2a9b). Nothing in this file consumes distribution_*version anymore. Could you drop the whole task?

[NikKumar811]

Thanks for tracing the history here. I removed the stale setup task from opensuse.yml since nothing in the file consumes those distribution version facts anymore.

[tico88612]

@NikKumar811 could you rebase your PR?

[NikKumar811]

@NikKumar811 could you rebase your PR?

Rebased the PR