-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: cri-o restart handler #11545
fix: cri-o restart handler #11545
Conversation
cri-o does not restart because import_role overwrites when conditional of the handler
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: snowamk The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Welcome @snowamk! |
Hi @snowamk. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/release-note-none |
/release-note-none
Hum there should be a release note, since it fix a bug.
|
If you fix the bug, the release note won't write BTW, please fix your CLA first. |
What type of PR is this?
/kind bug
What this PR does / why we need it:
cri-o does not restart because import_role overwrites the
when
conditional of the handlersame fix was made for containerd here: #9322
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?: