-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide missing advertise-address flag to kube-apiserver #11387
Provide missing advertise-address flag to kube-apiserver #11387
Conversation
Hi @derselbst. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: derselbst, mzaian The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
What this PR does / why we need it:
It is already possible to override the address the kube-apiserver is running on with the
kube_apiserver_address
variable. This variable is already expanded in line 10, however, it wasn't expanded for the kube-apiserver config and therefore, the kube-apiserver was started without the--advertise-address
flag, causing it to implicitly fall back to the--bind-address
. This PR fixes this, by passing on thekube_apiserver_address
to the kube-apiserver.Which issue(s) this PR fixes:
I'm not aware of an already existing ticket.
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
NONE