Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CentOS 7 yum repo baseurl update #11360

Merged
merged 1 commit into from
Jul 8, 2024
Merged

Fix CentOS 7 yum repo baseurl update #11360

merged 1 commit into from
Jul 8, 2024

Conversation

tico88612
Copy link
Member

What type of PR is this?

/kind failing-test
/kind feature

What this PR does / why we need it:

  • We previously removed the CI tests for CentOS 7 EOL, but the release-2.25 branch didn't keep up with the CI changes during this period, so release-2.25 could not be updated.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

CentOS 7 yum repo baseurl update

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. kind/feature Categorizes issue or PR as related to a new feature. labels Jul 7, 2024
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 7, 2024
@tico88612
Copy link
Member Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Jul 7, 2024
@tico88612 tico88612 force-pushed the feat/centos7-yum-repo-update branch 3 times, most recently from b0fff14 to 31c4f48 Compare July 7, 2024 14:07
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 7, 2024
@tico88612 tico88612 force-pushed the feat/centos7-yum-repo-update branch from 31c4f48 to d6353ac Compare July 7, 2024 14:41
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 7, 2024
@tico88612 tico88612 force-pushed the feat/centos7-yum-repo-update branch from d6353ac to e4c560a Compare July 7, 2024 15:01
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 7, 2024
ant31
ant31 reviewed Jul 7, 2024
View reviewed changes
.gitlab-ci/packet.yml Outdated Show resolved Hide resolved
ant31
ant31 reviewed Jul 7, 2024
View reviewed changes
.gitlab-ci/packet.yml Outdated Show resolved Hide resolved
@tico88612 tico88612 force-pushed the feat/centos7-yum-repo-update branch from e4c560a to 242ada9 Compare July 7, 2024 15:44
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 7, 2024
@ant31
Copy link
Contributor

ant31 commented Jul 7, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 7, 2024
@ant31
Copy link
Contributor

ant31 commented Jul 7, 2024

/approve

@ant31 ant31 removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 7, 2024
@tico88612 tico88612 force-pushed the feat/centos7-yum-repo-update branch from 242ada9 to 290ee2e Compare July 7, 2024 16:07
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 7, 2024
@tico88612 tico88612 changed the title Fix CentOS 7 yum repo baseurl update [WIP] Fix CentOS 7 yum repo baseurl update Jul 7, 2024
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 7, 2024
@tico88612
Feat: Update CentOS 7 EOL package to vault.centos.org
779bff4 
Signed-off-by: tico88612 <17496418+tico88612@users.noreply.github.com>
@tico88612 tico88612 force-pushed the feat/centos7-yum-repo-update branch from 290ee2e to 0a2385b Compare July 7, 2024 16:19
@tico88612
Copy link
Member Author

Ok, passed.

image

@tico88612 tico88612 force-pushed the feat/centos7-yum-repo-update branch from 0a2385b to 779bff4 Compare July 7, 2024 16:49
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 7, 2024
@tico88612 tico88612 changed the title [WIP] Fix CentOS 7 yum repo baseurl update Fix CentOS 7 yum repo baseurl update Jul 7, 2024
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 7, 2024
@MrFreezeex
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 8, 2024
@k8s-ci-robot k8s-ci-robot merged commit 464cc71 into kubernetes-sigs:master Jul 8, 2024
39 checks passed
@tico88612
Copy link
Member Author

tico88612 commented Jul 8, 2024 •
edited
Loading

/cherry-pick release-2.24

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Jul 8, 2024
Merged
@k8s-infra-cherrypick-robot
Copy link

@tico88612: new pull request created: #11364

In response to this:

/cherry-pick release-2.24
/cherry-pick release-2.25

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@tico88612
Copy link
Member Author

/cherry-pick release-2.25

@k8s-infra-cherrypick-robot
Copy link

@tico88612: new pull request created: #11365

In response to this:

/cherry-pick release-2.25

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Jul 8, 2024
Merged
@tico88612 tico88612 deleted the feat/centos7-yum-repo-update branch July 13, 2024 00:39
@yankay yankay mentioned this pull request Aug 28, 2024
Closed
@tico88612 tico88612 mentioned this pull request Oct 14, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ant31 ant31 ant31 left review comments

@cyclinder cyclinder Awaiting requested review from cyclinder

@MrFreezeex MrFreezeex Awaiting requested review from MrFreezeex

Assignees

@ant31 ant31

@MrFreezeex MrFreezeex

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tico88612 @ant31 @k8s-ci-robot @MrFreezeex @k8s-infra-cherrypick-robot