Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ingress-nginx] Create admission service automatically #11309

Conversation

mochizuki875
Copy link
Member

What type of PR is this?
/kind bug

What this PR does / why we need it:

Service/ingress-nginx-controller-admission which is target of ValidatingWebhookConfiguration/ingress-nginx-admission will not be created automatically when ingress_nginx_webhook_enabled: true and then, creating ingress will faild by validating webhook error because of it.
So in this PR, I’ve added template of service/ingress-nginx-controller-admission.

Which issue(s) this PR fixes:
Fixes #9545

Does this PR introduce a user-facing change?:

ingress-nginx-controller admission service is automatically created when `ingress_nginx_webhook_enabled: true`

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 20, 2024
Copy link
Contributor

@mzaian mzaian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Jun 20, 2024
@yankay yankay closed this Jun 21, 2024
@yankay yankay reopened this Jun 21, 2024
@yankay
Copy link
Member

yankay commented Jun 24, 2024

Thanks @mochizuki875
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mochizuki875, yankay

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 24, 2024
@mochizuki875
Copy link
Member Author

@yankay
Thank!
This PR seems to need /lgtm label, so could you add it?

@yankay
Copy link
Member

yankay commented Jun 24, 2024

@yankay Thank! This PR seems to need /lgtm label, so could you add it?

HI, @cyclinder would you please help to review it.

@ant31
Copy link
Contributor

ant31 commented Jun 26, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 26, 2024
@k8s-ci-robot k8s-ci-robot merged commit 88b502f into kubernetes-sigs:master Jun 26, 2024
79 checks passed
Rickkwa pushed a commit to Rickkwa/kubespray that referenced this pull request Jun 26, 2024
@mochizuki875
Copy link
Member Author

/cherrypick release-2.24

@mochizuki875
Copy link
Member Author

/cherrypick release-2.25

@k8s-infra-cherrypick-robot

@mochizuki875: new pull request created: #11331

In response to this:

/cherrypick release-2.24

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-infra-cherrypick-robot

@mochizuki875: new pull request created: #11332

In response to this:

/cherrypick release-2.25

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

service/ingress-nginx-controller and service/ingress-nginx-controller-admission doesnt exists
6 participants