-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ingress-nginx] Create admission service automatically #11309
[ingress-nginx] Create admission service automatically #11309
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ok-to-test
Thanks @mochizuki875 |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mochizuki875, yankay The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@yankay |
HI, @cyclinder would you please help to review it. |
/lgtm |
/cherrypick release-2.24 |
/cherrypick release-2.25 |
@mochizuki875: new pull request created: #11331 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@mochizuki875: new pull request created: #11332 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What type of PR is this?
/kind bug
What this PR does / why we need it:
Service/ingress-nginx-controller-admission
which is target ofValidatingWebhookConfiguration/ingress-nginx-admission
will not be created automatically wheningress_nginx_webhook_enabled: true
and then, creating ingress will faild by validating webhook error because of it.So in this PR, I’ve added template of service/ingress-nginx-controller-admission.
Which issue(s) this PR fixes:
Fixes #9545
Does this PR introduce a user-facing change?: