-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade upcloud csi driver to v1.1.0 and add snapshot features #11303
Upgrade upcloud csi driver to v1.1.0 and add snapshot features #11303
Conversation
Hi @Elias-elastisys. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this upstream with Upcloud CSI 1.1.0?
and suggestion about snapshot image tag variable.
roles/kubernetes-apps/csi_driver/upcloud/templates/upcloud-csi-controller.yml.j2
Outdated
Show resolved
Hide resolved
/ok-to-test |
Yes this is based off of that. |
c0beec6
to
8356610
Compare
8356610
to
cb9d590
Compare
Thanks @Elias-elastisys |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Elias-elastisys, robinAwallace, yankay The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Bump Upcloud csi driver version to v1.1.0 and adds necessary and left out snapshot features in order to enable Volume Snapshots (i.e. with
csi_snapshot_controller_enabled: true
)Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: