Cleanup nodelocaldns configuration #11238

evan-a-a · 2024-05-27T20:45:05Z

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
This PR makes some minor cleanups to the node local dns config. Notably, it aligns the labels with the kubernetes sample configuration and enables the use of templating values in the Corefile.

Does this PR introduce a user-facing change?:

NONE

linux-foundation-easycla · 2024-05-27T20:45:09Z

The committers listed above are authorized under a signed CLA.

✅ login: evan-a-a / name: Evan Anderson (001b16e, c6d9c16, 454be28)

k8s-ci-robot · 2024-05-27T20:45:14Z

Welcome @evan-a-a!

It looks like this is your first PR to kubernetes-sigs/kubespray 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kubespray has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

k8s-ci-robot · 2024-05-27T20:45:14Z

Hi @evan-a-a. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot · 2024-05-27T20:45:26Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: evan-a-a
Once this PR has been reviewed and has the lgtm label, please assign mzaian for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

* Use Corefile.base so that nodelocaldns supports templating

* Add label kubernetes.io/cluster-service: "true" * Set k8s-app label to node-local-dns

* Since we configure the upstream server through ansible templating, this arugment has no impact on node-cache

ant31 · 2024-05-28T07:52:04Z

roles/kubernetes-apps/ansible/templates/nodelocaldns-daemonset.yml.j2

@@ -42,9 +43,7 @@ spec:
        - -localip
        - {{ nodelocaldns_ip }}
        - -conf
-        - /etc/coredns/Corefile
-        - -upstreamsvc


why removing the upstreamsvc?

I explain this in the commit message, but this is a no-op in the Kubespray configuration, since we use Ansible to template the Corefile. The sole purpose of upstreamsvc is to replace __PILLAR__CLUSTER__DNS__ during templating from Corefile.base with the IP of the upstream service.

ant31 · 2024-05-28T07:53:38Z

roles/kubernetes-apps/ansible/templates/nodelocaldns-daemonset.yml.j2

-        - /etc/coredns/Corefile
-        - -upstreamsvc
-        - coredns
+        - /etc/Corefile


how is this file configured ?

Node-cache generates the Corefile from Corefile.base, substituting any templated values in the process.

ant31 · 2024-05-28T07:55:09Z

roles/kubernetes-apps/ansible/templates/nodelocaldns-daemonset.yml.j2

@@ -97,7 +96,7 @@ spec:
            name: nodelocaldns
            items:
            - key: Corefile
-              path: Corefile
+              path: Corefile.base


Corefile.base doesn't seem used anywhere

Ref #11238 (comment)

ant31 · 2024-05-28T08:09:24Z

Hi,
Thank you for the PR, and welcome ! 🥳

evan-a-a · 2024-05-28T17:46:49Z

This PR will make more sense in the context of a future PR I'm preparing to properly configure nodelocaldns when using cilium as the CNI. I decided to break out some of the cleanup stuff separately since it wasn't directly related.

k8s-triage-robot · 2024-08-26T18:37:35Z

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Mark this PR as fresh with /remove-lifecycle stale
Close this PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

VannTen · 2024-08-27T07:20:44Z

roles/kubernetes-apps/ansible/templates/nodelocaldns-daemonset.yml.j2

@@ -4,7 +4,8 @@ metadata:
  name: nodelocaldns
  namespace: kube-system
  labels:
-    k8s-app: kube-dns
+    k8s-app: node-local-dns
+    kubernetes.io/cluster-service: "true"


I think that label is deprecated. (I don't find direct reference, but see kubernetes/kubernetes#72757

k8s-triage-robot · 2024-09-26T07:28:22Z

The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Mark this PR as fresh with /remove-lifecycle rotten
Close this PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot · 2024-10-26T08:12:49Z

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Reopen this PR with /reopen
Mark this PR as fresh with /remove-lifecycle rotten
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

k8s-ci-robot · 2024-10-26T08:12:54Z

@k8s-triage-robot: Closed this PR.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied

After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied

After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Reopen this PR with /reopen

Mark this PR as fresh with /remove-lifecycle rotten

Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels May 27, 2024

k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label May 27, 2024

k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 27, 2024

k8s-ci-robot requested review from VannTen and yankay May 27, 2024 20:45

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels May 27, 2024

evan-a-a added 3 commits May 27, 2024 16:12

Fix nodelocaldns Corefile path

001b16e

* Use Corefile.base so that nodelocaldns supports templating

Reconcile nodelocaldns config with kubernetes sample config

454be28

* Add label kubernetes.io/cluster-service: "true" * Set k8s-app label to node-local-dns

Remove upstreamsvc option from nodelocaldns

c6d9c16

* Since we configure the upstream server through ansible templating, this arugment has no impact on node-cache

evan-a-a force-pushed the nodelocaldns_config_cleanup branch from 27204ea to c6d9c16 Compare May 27, 2024 21:13

ant31 reviewed May 28, 2024

View reviewed changes

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 26, 2024

VannTen reviewed Aug 27, 2024

View reviewed changes

k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Sep 26, 2024

k8s-ci-robot closed this Oct 26, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Cleanup nodelocaldns configuration #11238

Cleanup nodelocaldns configuration #11238

evan-a-a commented May 27, 2024 •

edited

Loading

linux-foundation-easycla bot commented May 27, 2024 •

edited

Loading

k8s-ci-robot commented May 27, 2024

k8s-ci-robot commented May 27, 2024

k8s-ci-robot commented May 27, 2024

ant31 May 28, 2024

evan-a-a May 28, 2024 •

edited

Loading

ant31 May 28, 2024

evan-a-a May 28, 2024

ant31 May 28, 2024

evan-a-a May 28, 2024

ant31 commented May 28, 2024

evan-a-a commented May 28, 2024 •

edited

Loading

k8s-triage-robot commented Aug 26, 2024

VannTen Aug 27, 2024

k8s-triage-robot commented Sep 26, 2024

k8s-triage-robot commented Oct 26, 2024

k8s-ci-robot commented Oct 26, 2024

Cleanup nodelocaldns configuration #11238

Cleanup nodelocaldns configuration #11238

Conversation

evan-a-a commented May 27, 2024 • edited Loading

linux-foundation-easycla bot commented May 27, 2024 • edited Loading

k8s-ci-robot commented May 27, 2024

k8s-ci-robot commented May 27, 2024

k8s-ci-robot commented May 27, 2024

ant31 May 28, 2024

Choose a reason for hiding this comment

evan-a-a May 28, 2024 • edited Loading

Choose a reason for hiding this comment

ant31 May 28, 2024

Choose a reason for hiding this comment

evan-a-a May 28, 2024

Choose a reason for hiding this comment

ant31 May 28, 2024

Choose a reason for hiding this comment

evan-a-a May 28, 2024

Choose a reason for hiding this comment

ant31 commented May 28, 2024

evan-a-a commented May 28, 2024 • edited Loading

k8s-triage-robot commented Aug 26, 2024

VannTen Aug 27, 2024

Choose a reason for hiding this comment

k8s-triage-robot commented Sep 26, 2024

k8s-triage-robot commented Oct 26, 2024

k8s-ci-robot commented Oct 26, 2024

evan-a-a commented May 27, 2024 •

edited

Loading

linux-foundation-easycla bot commented May 27, 2024 •

edited

Loading

evan-a-a May 28, 2024 •

edited

Loading

evan-a-a commented May 28, 2024 •

edited

Loading