Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump docker version from 24.0 to 26.1 #11198

Merged
merged 1 commit into from
May 16, 2024

Conversation

tico88612
Copy link
Member

@tico88612 tico88612 commented May 15, 2024

What type of PR is this?

/kind feature

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

I didn't find docker-ce version 24 in Ubuntu 24.04. Could we upgrade docker-ce to the latest (26.1)? (maybe relate README.md#container-runtime-notes)

Does this PR introduce a user-facing change?:

Docker upgrade from 24.0 to 26.1

Signed-off-by: tico88612 <17496418+tico88612@users.noreply.github.com>
@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 15, 2024
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 15, 2024
@yankay
Copy link
Member

yankay commented May 16, 2024

Thanks @tico88612

@ErikJiang would you please help to review it :-)

@ErikJiang
Copy link
Member

thanks @tico88612, looks good. I will handle the updates for Kylin and UnionTech.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 16, 2024
@ant31
Copy link
Contributor

ant31 commented May 16, 2024

/approve

@yankay
Copy link
Member

yankay commented May 16, 2024

Thanks @tico88612
/approve
/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ant31, tico88612, yankay

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 16, 2024
@k8s-ci-robot k8s-ci-robot merged commit 427f868 into kubernetes-sigs:master May 16, 2024
62 checks passed
@tico88612 tico88612 deleted the bump/docker-26.1 branch May 16, 2024 13:13
@yankay yankay mentioned this pull request May 21, 2024
@mzaian mzaian mentioned this pull request May 21, 2024
Rickkwa pushed a commit to Rickkwa/kubespray that referenced this pull request Jun 26, 2024
Signed-off-by: tico88612 <17496418+tico88612@users.noreply.github.com>
davidumea pushed a commit to elastisys/kubespray that referenced this pull request Oct 25, 2024
Signed-off-by: tico88612 <17496418+tico88612@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants