Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add selinux-ng repo in amazon linux to install container-selinux #11182

Merged

Conversation

yankay
Copy link
Member

@yankay yankay commented May 13, 2024

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:

Follow amazonlinux/amazon-linux-2023#56 (comment) , the container-selinux can be easily installed by amazon-linux-extras enable selinux-ng

So fix the broken CI https://gitlab.com/kargo-ci/kubernetes-sigs-kubespray/-/jobs/6831370040 , with add selinux-ng repo in amazon Linux.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

add `selinux-ng` repo in Amazon Linux to install `container-selinux`

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 13, 2024
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 13, 2024
@yankay yankay changed the title Fix broken CI which install container-selinux in amazon-linux Add selinux-ng repo in amazon linux to install container-selinux May 13, 2024
@yankay yankay force-pushed the fix-container-selinux-amzn-linux branch 2 times, most recently from 329b721 to 3b25733 Compare May 13, 2024 10:28
@yankay yankay closed this May 13, 2024
@yankay yankay reopened this May 13, 2024
@yankay yankay force-pushed the fix-container-selinux-amzn-linux branch from 3b25733 to dfeccaf Compare May 13, 2024 11:07
Copy link
Contributor

@mzaian mzaian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 13, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mzaian, yankay

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 7aa415e into kubernetes-sigs:master May 13, 2024
62 checks passed
@mzaian mzaian mentioned this pull request May 21, 2024
Rickkwa pushed a commit to Rickkwa/kubespray that referenced this pull request Jun 26, 2024
davidumea pushed a commit to elastisys/kubespray that referenced this pull request Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants