Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[etcd/tracing]: fix etcd sampling rate flag #11175

Merged
merged 1 commit into from
May 13, 2024
Merged

[etcd/tracing]: fix etcd sampling rate flag #11175

merged 1 commit into from
May 13, 2024

Conversation

ugur99
Copy link
Contributor

@ugur99 ugur99 commented May 7, 2024

What type of PR is this?
/kind bug

What this PR does / why we need it:
This MR fixes wrong env variable for etcd.

Which issue(s) this PR fixes:

Fixes # none

Special notes for your reviewer:
etcd monitoring document

Does this PR introduce a user-facing change?:

[etcd] fixes wrong distributed tracing flag for etcd

@ugur99
[etcd/tracing]: fix etcd sampling rate flag
3cafbb8 
Signed-off-by: Ugur Ozturk <ugurozturk918@gmail.com>
@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label May 7, 2024
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 7, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @ugur99. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 7, 2024
@ugur99
Copy link
Contributor Author

ugur99 commented May 7, 2024

Hi @mzaian and @yankay! Sorry for tagging you here, but I just realized that I made a typo in one of the etcd tracing flags. This MR fixes the problem. I thought it would be nice if we could merge and include this for the next release.

@mzaian
Copy link
Contributor

mzaian commented May 7, 2024

Hi @mzaian and @yankay! Sorry for tagging you here, but I just realized that I made a typo in one of the etcd tracing flags. This MR fixes the problem. I thought it would be nice if we could merge and include this for the next release.

Thanks for catching this @ugur99

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 7, 2024
@ugur99
Copy link
Contributor Author

ugur99 commented May 12, 2024

Hi @mzaian! anything you want me to work on regarding this PR?

mzaian
mzaian approved these changes May 13, 2024
View reviewed changes
Copy link
Contributor

@mzaian mzaian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 13, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mzaian, ugur99

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 13, 2024
@k8s-ci-robot k8s-ci-robot merged commit a512b86 into kubernetes-sigs:master May 13, 2024
60 checks passed
@mzaian mzaian mentioned this pull request May 21, 2024
Closed
Rickkwa pushed a commit to Rickkwa/kubespray that referenced this pull request Jun 26, 2024
@ugur99 @Rickkwa
[etcd/tracing]: fix etcd sampling rate flag (kubernetes-sigs#11175)
5899136 
Signed-off-by: Ugur Ozturk <ugurozturk918@gmail.com>
davidumea pushed a commit to elastisys/kubespray that referenced this pull request Oct 25, 2024
@ugur99 @davidumea
[etcd/tracing]: fix etcd sampling rate flag (kubernetes-sigs#11175)
587a193 
Signed-off-by: Ugur Ozturk <ugurozturk918@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mzaian mzaian mzaian approved these changes

@cyclinder cyclinder Awaiting requested review from cyclinder

@yankay yankay Awaiting requested review from yankay

Assignees

@mzaian mzaian

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ugur99 @k8s-ci-robot @mzaian