CI: Factorize ansible-playbook flags #11173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
kind/cleanup
k8s-ci-robot
added
cncf-cla: yes
VannTen
force-pushed
the
fix/consistent_ci_settings
branch
2 times, most recently
from
378d1c5
to
598e73f
Compare
|
Yeah I was in a hurry, I'll fix that.
|
VannTen
force-pushed
the
fix/consistent_ci_settings
branch
from
598e73f
to
7d45113
Compare
We have inconsistent sets of options passed to the playbooks during our CI runs. Don't run ansible-playbook directly, instead factorize the execution in a bash function using all the common flags. Also remove various ENABLE_* variables and instead directly test for the relevant conditions at execution time, as this makes it more obvious and does not force one to go back and forth in the script.
VannTen
force-pushed
the
fix/consistent_ci_settings
branch
from
7d45113
to
3893871
Compare
k8s-ci-robot
added
the
lgtm
|
/assign @mzaian I don't know why, but my email replies are getting lost by github. Super annoying... |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: MrFreezeex, mzaian, VannTen The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Rickkwa
pushed a commit
to Rickkwa/kubespray
that referenced
this pull request
Jun 26, 2024
We have inconsistent sets of options passed to the playbooks during our CI runs. Don't run ansible-playbook directly, instead factorize the execution in a bash function using all the common flags. Also remove various ENABLE_* variables and instead directly test for the relevant conditions at execution time, as this makes it more obvious and does not force one to go back and forth in the script.
tmurakam
added a commit
to tmurakam/kubespray
that referenced
this pull request
Aug 18, 2024
Need to checkout CI_COMMIT_SHA before running upgrade playbook (revert kubernetes-sigs#11173 partially)
tmurakam
added a commit
to tmurakam/kubespray
that referenced
this pull request
Aug 18, 2024
Need to git checkout ${CI_COMMIT_SHA} before running upgrade playbook (revert kubernetes-sigs#11173 partially)
tmurakam
added a commit
to tmurakam/kubespray
that referenced
this pull request
Aug 29, 2024
Need to git checkout ${CI_COMMIT_SHA} before running upgrade playbook (revert kubernetes-sigs#11173 partially)
tmurakam
added a commit
to tmurakam/kubespray
that referenced
this pull request
Aug 29, 2024
Need to git checkout ${CI_COMMIT_SHA} before running upgrade playbook (revert kubernetes-sigs#11173 partially)
davidumea
pushed a commit
to elastisys/kubespray
that referenced
this pull request
Oct 25, 2024
We have inconsistent sets of options passed to the playbooks during our CI runs. Don't run ansible-playbook directly, instead factorize the execution in a bash function using all the common flags. Also remove various ENABLE_* variables and instead directly test for the relevant conditions at execution time, as this makes it more obvious and does not force one to go back and forth in the script.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
We have inconsistent sets of options passed to the playbooks during our
CI runs.
Don't run ansible-playbook directly, instead factorize the execution in
a bash function using all the common flags.
Also remove various ENABLE_* variables and instead directly test for the
relevant conditions at execution time, as this makes it more obvious and
does not force one to go back and forth in the script.
This fix problems such as not having the logs in CI runs like in #11132
Does this PR introduce a user-facing change?: