-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add the ability to configure extra args to the different cinder-csi-p… #11169
Conversation
Hi @Payback159. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
Thanks @Payback159 |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Payback159, yankay The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
kubernetes-sigs#11169) * add the ability to configure extra args to the different cinder-csi-plugin containers * endfor block added to be syntactically correct jinja
kubernetes-sigs#11169) * add the ability to configure extra args to the different cinder-csi-plugin containers * endfor block added to be syntactically correct jinja
…lugin containers
What type of PR is this?
/kind feature
What this PR does / why we need it:
Adds the possibility to add extra arguments to the various containers in the cinder-csi plugin.
Which issue(s) this PR fixes:
Fixes #11115
Special notes for your reviewer:
In #11115 is only the request for the liveness-probe container. But I thought it would also be interesting to be able to configure the other containers in the csi-cinder daemonset with extra arguments. I am open to both ways.
Does this PR introduce a user-facing change?: