Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Volume Snapshot Controller to 7.0.2 #11041

Merged

Conversation

jess-sol
Copy link
Contributor

@jess-sol jess-sol commented Mar 28, 2024

What type of PR is this?
/kind bug

What this PR does / why we need it:
Kubernetes v1.29 installs snapshot controller v7.0.2, which requires an updated ClusterRole to work.

Which issue(s) this PR fixes:

Fixes #11037

Does this PR introduce a user-facing change?:

Update Snapshot Controller to 7.0.2 for all supported Kubernetes versions.

@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Mar 28, 2024
Copy link

linux-foundation-easycla bot commented Mar 28, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: jess-sol / name: J (e5cbb68)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Mar 28, 2024
@k8s-ci-robot
Copy link
Contributor

Welcome @jess-sol!

It looks like this is your first PR to kubernetes-sigs/kubespray 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kubespray has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 28, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @jess-sol. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 28, 2024
@jess-sol jess-sol force-pushed the topic/fix-snapshot-controller branch from 367f700 to b386b15 Compare March 28, 2024 16:44
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Mar 28, 2024
@yankay
Copy link
Member

yankay commented Mar 29, 2024

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 29, 2024
Copy link
Contributor

@mzaian mzaian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @jess-sol

Thank you and could you please make the changes permanent and update the controller version for all the corresponding kubernetes versions here: https://github.com/kubernetes-sigs/kubespray/blob/master/roles/kubespray-defaults/defaults/main/download.yml#L360-L363

Also it's a good opportunity to go up to the latest version https://github.com/kubernetes-csi/external-snapshotter/releases/tag/v7.0.1

@jess-sol jess-sol force-pushed the topic/fix-snapshot-controller branch from b386b15 to 24d4073 Compare April 1, 2024 19:06
@jess-sol
Copy link
Contributor Author

jess-sol commented Apr 1, 2024

Hey @mzaian, I've gone ahead and updated all supported versions of k8s to use external snapshotter 7.0.2, and updated the deployment manifests to parallel those available in the external-snapshotter repo for version 7.0.2. I tested a single deployment with k8s 1.29, and it looks fine. Let me know if anything looks amiss. Thanks!

@jess-sol jess-sol requested a review from mzaian April 2, 2024 03:26
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jess-sol, mzaian

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 2, 2024
@mzaian
Copy link
Contributor

mzaian commented Apr 2, 2024

Hey @mzaian, I've gone ahead and updated all supported versions of k8s to use external snapshotter 7.0.2, and updated the deployment manifests to parallel those available in the external-snapshotter repo for version 7.0.2. I tested a single deployment with k8s 1.29, and it looks fine. Let me know if anything looks amiss. Thanks!

Thanks a lot @jess-sol

/cc @VannTen @yankay

@mzaian
Copy link
Contributor

mzaian commented Apr 2, 2024

@jess-sol
Maybe change the PR title and please add a release note about the changes.

@jess-sol jess-sol changed the title Add updated ClusterRole for volume-snapshot-controller Update Volume Snapshot Controller to 7.0.2 Apr 2, 2024
Upgrade Snapshot controller installed for all supported Kubernetes
versions to v7.0.2. Also update the manifests used to deploy the
Snapshot controller.
@jess-sol jess-sol force-pushed the topic/fix-snapshot-controller branch from 24d4073 to e5cbb68 Compare April 2, 2024 18:31
@jess-sol
Copy link
Contributor Author

jess-sol commented Apr 2, 2024

Okay should be good now @mzaian

@mzaian
Copy link
Contributor

mzaian commented Apr 2, 2024

Okay should be good now @mzaian

Thank you
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 2, 2024
- apiGroups: ["snapshot.storage.k8s.io"]
resources: ["volumesnapshots"]
verbs: ["get", "list", "watch", "update"]
verbs: ["get", "list", "watch", "update", "patch", "delete"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
verbs: ["get", "list", "watch", "update", "patch", "delete"]
verbs: ["get", "list", "watch", "update", "delete", "patch"]

same sequence as above will be better

@k8s-ci-robot k8s-ci-robot merged commit 8a423ab into kubernetes-sigs:master Apr 11, 2024
60 checks passed
@mzaian mzaian mentioned this pull request Apr 26, 2024
dibi-codes pushed a commit to fino-digital/kubespray that referenced this pull request May 7, 2024
Upgrade Snapshot controller installed for all supported Kubernetes
versions to v7.0.2. Also update the manifests used to deploy the
Snapshot controller.
pedro-peter pushed a commit to pedro-peter/kubespray that referenced this pull request May 8, 2024
Upgrade Snapshot controller installed for all supported Kubernetes
versions to v7.0.2. Also update the manifests used to deploy the
Snapshot controller.
Rickkwa pushed a commit to Rickkwa/kubespray that referenced this pull request Jun 26, 2024
Upgrade Snapshot controller installed for all supported Kubernetes
versions to v7.0.2. Also update the manifests used to deploy the
Snapshot controller.
davidumea pushed a commit to elastisys/kubespray that referenced this pull request Oct 25, 2024
Upgrade Snapshot controller installed for all supported Kubernetes
versions to v7.0.2. Also update the manifests used to deploy the
Snapshot controller.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Volume snapshot controller ClusterRole incorrect in K8s v1.29
5 participants