-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Volume Snapshot Controller to 7.0.2 #11041
Update Volume Snapshot Controller to 7.0.2 #11041
Conversation
|
Welcome @jess-sol! |
Hi @jess-sol. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
367f700
to
b386b15
Compare
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @jess-sol
Thank you and could you please make the changes permanent and update the controller version for all the corresponding kubernetes versions here: https://github.com/kubernetes-sigs/kubespray/blob/master/roles/kubespray-defaults/defaults/main/download.yml#L360-L363
Also it's a good opportunity to go up to the latest version https://github.com/kubernetes-csi/external-snapshotter/releases/tag/v7.0.1
b386b15
to
24d4073
Compare
Hey @mzaian, I've gone ahead and updated all supported versions of k8s to use external snapshotter 7.0.2, and updated the deployment manifests to parallel those available in the external-snapshotter repo for version 7.0.2. I tested a single deployment with k8s 1.29, and it looks fine. Let me know if anything looks amiss. Thanks! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jess-sol, mzaian The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thanks a lot @jess-sol |
@jess-sol |
Upgrade Snapshot controller installed for all supported Kubernetes versions to v7.0.2. Also update the manifests used to deploy the Snapshot controller.
24d4073
to
e5cbb68
Compare
Okay should be good now @mzaian |
Thank you |
- apiGroups: ["snapshot.storage.k8s.io"] | ||
resources: ["volumesnapshots"] | ||
verbs: ["get", "list", "watch", "update"] | ||
verbs: ["get", "list", "watch", "update", "patch", "delete"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
verbs: ["get", "list", "watch", "update", "patch", "delete"] | |
verbs: ["get", "list", "watch", "update", "delete", "patch"] |
same sequence as above will be better
Upgrade Snapshot controller installed for all supported Kubernetes versions to v7.0.2. Also update the manifests used to deploy the Snapshot controller.
Upgrade Snapshot controller installed for all supported Kubernetes versions to v7.0.2. Also update the manifests used to deploy the Snapshot controller.
Upgrade Snapshot controller installed for all supported Kubernetes versions to v7.0.2. Also update the manifests used to deploy the Snapshot controller.
Upgrade Snapshot controller installed for all supported Kubernetes versions to v7.0.2. Also update the manifests used to deploy the Snapshot controller.
What type of PR is this?
/kind bug
What this PR does / why we need it:
Kubernetes v1.29 installs snapshot controller v7.0.2, which requires an updated ClusterRole to work.
Which issue(s) this PR fixes:
Fixes #11037
Does this PR introduce a user-facing change?: