-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow specifying CPU Manager Policy Options #11023
Allow specifying CPU Manager Policy Options #11023
Conversation
|
Welcome @derselbst! |
Hi @derselbst. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for you contribution!
See the comment inline.
/ok-to-test
7b9b6a3
to
06c87af
Compare
06c87af
to
547f9ff
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks :D
/lgtm
Thanks @derselbst |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: derselbst, MrFreezeex, yankay The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
What this PR does / why we need it:
Kubespray already provides the
kubelet_cpu_manager_policy
option to specify thestatic
CPU Manager. However, it lacks the ability to also specify policy options. This PR addskubelet_cpu_manager_policy_options
, a YAML dictionary allowing to specify the policy options following the official documentation.Special notes for your reviewer:
Does this PR introduce a user-facing change?:
NONE