-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add docker ansible tag #11002
base: master
Are you sure you want to change the base?
Add docker ansible tag #11002
Conversation
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten |
@tu1h Could you rebase this PR to upstream? |
Signed-off-by: tu1h <lihai.tu@daocloud.io>
a7eeb63
to
0df4085
Compare
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: tu1h The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Done |
/ok-to-test |
/remove-lifecycle rotten |
@VannTen, what do you think of this PR? |
I think you can already do `deploy_container_engine: false` to not deploy docker (or anything else), is that not appropriate here for some reason ?
|
Hi @VannTen, In a senario, there was a already installed docker in node, but no K8s-related components (like cri-dockerd), just only intending to skip docker installation for reusing it when run |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Add new fine-grained tag to make it possible to skip docker installation by running the command
ansible-playbook --skip-tags docker-engine ...
.This is suitable for a scenario where docker is already installed on a node and there are already business applications running on top of docker, and I want to use this docker again as the underlying runtime for k8s and don't want to change any of the docker's configurations.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: