Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust galaxy.yml #10906

Merged
merged 1 commit into from
Feb 9, 2024
Merged

Adjust galaxy.yml #10906

merged 1 commit into from
Feb 9, 2024

Conversation

VannTen
Copy link
Contributor

@VannTen VannTen commented Feb 8, 2024 •
edited by floryut
Loading

What type of PR is this?
/kind cleanup

Which issue(s) this PR fixes:
Fixes #10248

Does this PR introduce a user-facing change?:

Fixup galaxy.yml

/cc @MrFreezeex

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 8, 2024
MrFreezeex
MrFreezeex approved these changes Feb 8, 2024
View reviewed changes
Copy link
Member

@MrFreezeex MrFreezeex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yep indeed I forgot about this issue 👍
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 8, 2024
@VannTen
Copy link
Contributor Author

VannTen commented Feb 9, 2024

/assign @yankay

@VannTen
Copy link
Contributor Author

VannTen commented Feb 9, 2024

/assign @mzaian

floryut
floryut approved these changes Feb 9, 2024
View reviewed changes
Copy link
Member

@floryut floryut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@VannTen all good 👍

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floryut, MrFreezeex, VannTen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 9, 2024
@k8s-ci-robot k8s-ci-robot merged commit ad9f194 into kubernetes-sigs:master Feb 9, 2024
65 checks passed
@mzaian mzaian mentioned this pull request Apr 26, 2024
Closed
dibi-codes pushed a commit to fino-digital/kubespray that referenced this pull request May 7, 2024
@VannTen @dibi-codes
Adjust galaxy.yml (kubernetes-sigs#10906)
4176a1e
pedro-peter pushed a commit to pedro-peter/kubespray that referenced this pull request May 8, 2024
@VannTen @pedromcpedro
Adjust galaxy.yml (kubernetes-sigs#10906)
e24101c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@floryut floryut floryut approved these changes

@MrFreezeex MrFreezeex MrFreezeex approved these changes

Assignees

@mzaian mzaian

@yankay yankay

@MrFreezeex MrFreezeex

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

galaxy.yml is missing licencse / license_file
6 participants
@VannTen @k8s-ci-robot @MrFreezeex @floryut @mzaian @yankay