-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Docker version to v24.0 #10873
Update Docker version to v24.0 #10873
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: yankay The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
68b9ace
to
142c83f
Compare
b4aa8ad
to
ff87398
Compare
Signed-off-by: Kay Yan <kay.yan@daocloud.io>
ff87398
to
db34dcf
Compare
HI @VannTen Would you please review the PR :-) |
Currently, there are issues with installing Docker version 23.0 on the Kylin system. The error message is as follows: [root@localhost ~]# cat /etc/os-release
NAME="Kylin Linux Advanced Server"
VERSION="V10 (Sword)"
ID="kylin"
VERSION_ID="V10"
PRETTY_NAME="Kylin Linux Advanced Server V10 (Sword)"
ANSI_COLOR="0;31"
[root@localhost ~]# dnf install docker-ce-3:23.0.6-1.el8 --enablerepo=docker-ce
Last metadata expiration check: 0:05:11 ago on Mon 05 Feb 2024 11:42:03 AM CST.
Error:
Problem: package docker-ce-3:23.0.6-1.el8.aarch64 requires docker-ce-rootless-extras, but none of the providers can be installed
- conflicting requests
- nothing provides fuse-overlayfs >= 0.7 needed by docker-ce-rootless-extras-20.10.0-3.el8.aarch64
- nothing provides slirp4netns >= 0.4 needed by docker-ce-rootless-extras-20.10.0-3.el8.aarch64
... I'm not sure if this type of problem would also occur on other systems. |
HI @ErikJiang The PR doest not change the docker version of Kylin Linux, ref https://github.com/kubernetes-sigs/kubespray/blob/master/roles/container-engine/docker/vars/kylin.yml#L28. And we can use the old version of docker 19.03 & coredns 1.10 instead. BTW, the container is more recommended than docker-ce. |
thanks @yankay /lgtm |
Signed-off-by: Kay Yan <kay.yan@daocloud.io>
Signed-off-by: Kay Yan <kay.yan@daocloud.io>
What type of PR is this?
/kind feature
What this PR does / why we need it:
Update the docker default version to 24.0
Which issue(s) this PR fixes:
Fixes #10869
Fixes #10767
Fixes CVE-2024-21626
Special notes for your reviewer:
Does this PR introduce a user-facing change?: