Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Docker version to v24.0 #10873

Merged
merged 1 commit into from
Feb 5, 2024

Conversation

yankay
Copy link
Member

@yankay yankay commented Feb 4, 2024

What type of PR is this?

/kind feature

What this PR does / why we need it:

Update the docker default version to 24.0

Which issue(s) this PR fixes:

Fixes #10869
Fixes #10767
Fixes CVE-2024-21626

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Update the docker default version to 24.0

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Feb 4, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: yankay

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 4, 2024
@yankay yankay changed the title Update Docker version to 24.0 Update Docker version to v24.0 Feb 4, 2024
@yankay yankay force-pushed the make-docker-24-default branch 5 times, most recently from b4aa8ad to ff87398 Compare February 4, 2024 12:44
Signed-off-by: Kay Yan <kay.yan@daocloud.io>
@yankay
Copy link
Member Author

yankay commented Feb 5, 2024

HI @VannTen

Would you please review the PR :-)

@ErikJiang
Copy link
Member

Currently, there are issues with installing Docker version 23.0 on the Kylin system. The error message is as follows:

[root@localhost ~]# cat /etc/os-release
NAME="Kylin Linux Advanced Server"
VERSION="V10 (Sword)"
ID="kylin"
VERSION_ID="V10"
PRETTY_NAME="Kylin Linux Advanced Server V10 (Sword)"
ANSI_COLOR="0;31"

[root@localhost ~]# dnf install docker-ce-3:23.0.6-1.el8 --enablerepo=docker-ce
Last metadata expiration check: 0:05:11 ago on Mon 05 Feb 2024 11:42:03 AM CST.
Error:
 Problem: package docker-ce-3:23.0.6-1.el8.aarch64 requires docker-ce-rootless-extras, but none of the providers can be installed
  - conflicting requests
  - nothing provides fuse-overlayfs >= 0.7 needed by docker-ce-rootless-extras-20.10.0-3.el8.aarch64
  - nothing provides slirp4netns >= 0.4 needed by docker-ce-rootless-extras-20.10.0-3.el8.aarch64
  ...

I'm not sure if this type of problem would also occur on other systems.
@yankay

@yankay
Copy link
Member Author

yankay commented Feb 5, 2024

Currently, there are issues with installing Docker version 23.0 on the Kylin system. The error message is as follows:

[root@localhost ~]# cat /etc/os-release
NAME="Kylin Linux Advanced Server"
VERSION="V10 (Sword)"
ID="kylin"
VERSION_ID="V10"
PRETTY_NAME="Kylin Linux Advanced Server V10 (Sword)"
ANSI_COLOR="0;31"

[root@localhost ~]# dnf install docker-ce-3:23.0.6-1.el8 --enablerepo=docker-ce
Last metadata expiration check: 0:05:11 ago on Mon 05 Feb 2024 11:42:03 AM CST.
Error:
 Problem: package docker-ce-3:23.0.6-1.el8.aarch64 requires docker-ce-rootless-extras, but none of the providers can be installed
  - conflicting requests
  - nothing provides fuse-overlayfs >= 0.7 needed by docker-ce-rootless-extras-20.10.0-3.el8.aarch64
  - nothing provides slirp4netns >= 0.4 needed by docker-ce-rootless-extras-20.10.0-3.el8.aarch64
  ...

I'm not sure if this type of problem would also occur on other systems. @yankay

HI @ErikJiang

The PR doest not change the docker version of Kylin Linux, ref https://github.com/kubernetes-sigs/kubespray/blob/master/roles/container-engine/docker/vars/kylin.yml#L28.

And we can use the old version of docker 19.03 & coredns 1.10 instead. BTW, the container is more recommended than docker-ce.

@ErikJiang
Copy link
Member

thanks @yankay

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 5, 2024
@k8s-ci-robot k8s-ci-robot merged commit c9a44e4 into kubernetes-sigs:master Feb 5, 2024
65 checks passed
@floryut floryut added kind/container-managers Containers section in the release note and removed kind/feature Categorizes issue or PR as related to a new feature. labels Feb 5, 2024
@mzaian mzaian mentioned this pull request Apr 26, 2024
dibi-codes pushed a commit to fino-digital/kubespray that referenced this pull request May 7, 2024
Signed-off-by: Kay Yan <kay.yan@daocloud.io>
pedro-peter pushed a commit to pedro-peter/kubespray that referenced this pull request May 8, 2024
Signed-off-by: Kay Yan <kay.yan@daocloud.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/container-managers Containers section in the release note lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI: coredns crashloopbackoff in packet_centos7-calico-ha-once-localhost Docker version is not supported
4 participants