Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 'system-packages' tag to control installing packages from OS repos #10872

Merged
merged 1 commit into from
May 30, 2024
Merged

Add 'system-packages' tag to control installing packages from OS repos #10872

merged 1 commit into from
May 30, 2024

Conversation

hedayat
Copy link
Contributor

@hedayat hedayat commented Feb 3, 2024

What type of PR is this?
/kind feature

What this PR does / why we need it: Adds system-packages tag to control installing package dependencies using OS package manager

Which issue(s) this PR fixes: 10871

Fixes #10871

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

You can now disable installing OS dependencies using system's package manager by skipping `system-packages` tag.

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 3, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @hedayat. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 3, 2024
@yankay
Copy link
Member

yankay commented Feb 5, 2024

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 5, 2024
VannTen
VannTen reviewed Feb 5, 2024
View reviewed changes
docs/offline-environment.md Outdated
@@ -103,7 +103,9 @@ If you use the settings like the one above, you'll need to define in your invent
can store them anywhere as long as it's accessible by kubespray. It's recommended to use `*_version` in the path so
that you don't need to modify this setting everytime kubespray upgrades one of these components.
* `yum_repo`/`debian_repo`/`ubuntu_repo`: OS package repository depending on your OS, should point to your internal
repository. Adjust the path accordingly.
repository. Adjust the path accordingly. Used only for Docker/Containerd packages (if needed); other packages might
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is that still correct ? I mean, are we not getting containerd from upstream rather than distro packages ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TBH, I've not checked all cases. But under Ubuntu, you are correct, at least under Ubuntu 20/22 we do not install it from apt repos. But I was not sure if it is true in all cases :P This is why I added the "(if needed)" part. :D

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that's the case, but it's probably worth checking

Copy link
Contributor Author

@hedayat hedayat Feb 15, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, it is no longer used for Containerd, but seems to be still used for docker.

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 16, 2024
@hedayat
Copy link
Contributor Author

hedayat commented May 17, 2024

/remove-lifecycle stale

Well, it just needs a 1-2 min review!! :(

@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels May 17, 2024
@hedayat
Copy link
Contributor Author

hedayat commented May 17, 2024

/remove-lifecycle stale

Well, it just needs a 1-2 min review!! :(

@yankay
Copy link
Member

yankay commented May 20, 2024

/remove-lifecycle stale

Well, it just needs a 1-2 min review!! :(

Thanks @hedayat
The PR needs to reslove the conflicts.

@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 29, 2024
@hedayat
Copy link
Contributor Author

hedayat commented May 29, 2024

@yankay Thanks. Conflicts are resolved now.

@yankay
Copy link
Member

yankay commented May 30, 2024

Thanks @hedayat
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hedayat, yankay

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 30, 2024
@VannTen
Copy link
Contributor

VannTen commented May 30, 2024 via email

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 30, 2024
@VannTen
Copy link
Contributor

VannTen commented May 30, 2024 via email

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 30, 2024
@hedayat
Copy link
Contributor Author

hedayat commented May 30, 2024

Rebased

@VannTen
Copy link
Contributor

VannTen commented May 30, 2024 via email

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 30, 2024
@k8s-ci-robot k8s-ci-robot merged commit dedc006 into kubernetes-sigs:master May 30, 2024
77 checks passed
ehsan310 pushed a commit to ehsan310/kubespray that referenced this pull request May 31, 2024
@hedayat @ehsan310
Add 'system-packages' tag to control installing packages from OS repo…
043b855 
…sitories (kubernetes-sigs#10872)
Rickkwa pushed a commit to Rickkwa/kubespray that referenced this pull request Jun 26, 2024
@hedayat @Rickkwa
Add 'system-packages' tag to control installing packages from OS repo…
f2d3afe 
…sitories (kubernetes-sigs#10872)
@yankay yankay mentioned this pull request Aug 28, 2024
Closed
davidumea pushed a commit to elastisys/kubespray that referenced this pull request Oct 25, 2024
@hedayat @davidumea
Add 'system-packages' tag to control installing packages from OS repo…
1f439c0 
…sitories (kubernetes-sigs#10872)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VannTen VannTen VannTen left review comments

@ErikJiang ErikJiang Awaiting requested review from ErikJiang

@yankay yankay Awaiting requested review from yankay

Assignees

@VannTen VannTen

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a tag to control installing packages from OS/add-on repositories
5 participants
@hedayat @k8s-ci-robot @yankay @k8s-triage-robot @VannTen