Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make containerd 1.7.13 default and upgrade runc to v1.1.12 #10862

Merged
merged 1 commit into from
Feb 1, 2024

Conversation

KubeKyrie
Copy link
Contributor

@KubeKyrie KubeKyrie commented Jan 31, 2024

What type of PR is this?
/kind feature

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #10784

Special notes for your reviewer:
containerd 1.7.13 release notes https://github.com/containerd/containerd/releases/tag/v1.7.13
containerd 1.7.12 release notes https://github.com/containerd/containerd/releases/tag/v1.7.12
add runc v1.1.12, v1.1.11
add containerd 1.7.13, 1.7.12

Does this PR introduce a user-facing change?:

[containerd] Make containerd 1.7.13 default
[runc] Upgrade to v1.1.12

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 31, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @KubeKyrie. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 31, 2024
@yankay
Copy link
Member

yankay commented Jan 31, 2024

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 31, 2024
@madddi
Copy link

madddi commented Feb 1, 2024

Hi,

you should probably move to runc 1.1.12 because of GHSA-xr7r-f8xq-vfvv

@mzaian
Copy link
Contributor

mzaian commented Feb 1, 2024

Hi,

you should probably move to runc 1.1.12 because of GHSA-xr7r-f8xq-vfvv

Hello @KubeKyrie

Also please consider adding containerd 1.6.28 amd 1.7.13 because containerd 1.6.28 and 1.7.13 have been released to include runc 1.1.12 with fix for CVE-2024-21626!

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 1, 2024
@mzaian
Copy link
Contributor

mzaian commented Feb 1, 2024

k/k Is also bumping up the runc version kubernetes/kubernetes#123060

Signed-off-by: KubeKyrie <shaolong.qin@daocloud.io>
@KubeKyrie KubeKyrie changed the title make containerd 1.7.12 default and upgrade runc to v1.1.11 make containerd 1.7.13 default and upgrade runc to v1.1.12 Feb 1, 2024
@mzaian
Copy link
Contributor

mzaian commented Feb 1, 2024

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 1, 2024
@VannTen
Copy link
Contributor

VannTen commented Feb 1, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 1, 2024
@VannTen
Copy link
Contributor

VannTen commented Feb 1, 2024

/assign @mzaian

Copy link
Contributor

@mzaian mzaian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @KubeKyrie

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: KubeKyrie, mzaian

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 1, 2024
@k8s-ci-robot k8s-ci-robot merged commit 0dbde75 into kubernetes-sigs:master Feb 1, 2024
65 checks passed
@floryut floryut added kind/container-managers Containers section in the release note and removed kind/feature Categorizes issue or PR as related to a new feature. labels Feb 5, 2024
@mzaian mzaian mentioned this pull request Apr 26, 2024
pedro-peter pushed a commit to pedro-peter/kubespray that referenced this pull request May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/container-managers Containers section in the release note lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bump runc version to 1.1.11
8 participants