Adjust kubelet_event_record_qps to K8S default #10826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also remove redundant check in the kubelet config template (we define a default, so the setting will always be "true")
k8s-ci-robot
added
kind/cleanup
k8s-ci-robot
added
the
size/XS
k8s-ci-robot
added
the
lgtm
floryut
approved these changes
Jan 22, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: floryut, MrFreezeex, VannTen The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
pedro-peter
pushed a commit
to pedro-peter/kubespray
that referenced
this pull request
May 8, 2024
Also remove redundant check in the kubelet config template (we define a default, so the setting will always be "true")
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Use the same default as K8S (we should not unecessarily deviate from K8S defaults)
Also remove redundant check in the kubelet config template (we define a default, so the setting will always be "true")
Which issue(s) this PR fixes:
Fixes #10753
Special notes for your reviewer:
Does this PR introduce a user-facing change?: