-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[2.22] Add k8s patches version, default to 1.26.13 #10823
[2.22] Add k8s patches version, default to 1.26.13 #10823
Conversation
Make kubernetes 1.26.13 default
1d3953b
to
8b976c5
Compare
/cc @MrFreezeex |
/cc @mzaian |
Agreed, that's really something that we are missing, some kind of label to automate backport to n-x branches |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
We should most likely have a way to track backport but not sure if it would be sufficient here as there is a different default k8s version for each branch 🤔. |
I would say we should not be adding those hashes to prior releases If no CVEs or security related fixes. Or At least we supply them to 1 older release. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: MrFreezeex, mzaian, VannTen The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@@ -0,0 +1,3 @@ | |||
--- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@VannTen Hello, may I ask if this file is redundant? The actual checksum information is stored in the roles/download/defaults/main.yml
file. I'm not quite sure what the purpose of this new file is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hum, yeah, not sure how this got there. 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😊Do you have time to verify if this file is useless? If it is, I suggest removing it. Thank you very much.🤝
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hum it does not appear to be in release-2.22 though.. 🤔
What type of PR is this?
/kind feature
What this PR does / why we need it:
Make kubernetes 1.26.13 default, add last patch versions for all supported major versions
Which issue(s) this PR fixes:
Fixes #10333
Special notes for your reviewer:
Does this PR introduce a user-facing change?: