Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.22] Add k8s patches version, default to 1.26.13 #10823

Merged

Conversation

VannTen
Copy link
Contributor

@VannTen VannTen commented Jan 22, 2024

What type of PR is this?
/kind feature

What this PR does / why we need it:

Make kubernetes 1.26.13 default, add last patch versions for all supported major versions

Which issue(s) this PR fixes:

Fixes #10333

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Make kubernetes 1.26.13 the default version

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 22, 2024
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 22, 2024
@VannTen
Copy link
Contributor Author

VannTen commented Jan 22, 2024

/cc @MrFreezeex
We need to automate that stuff.... I wonder if Prow can do PRs itself ? 🤔

@VannTen
Copy link
Contributor Author

VannTen commented Jan 22, 2024

/cc @mzaian

@floryut
Copy link
Member

floryut commented Jan 22, 2024

/cc @MrFreezeex We need to automate that stuff.... I wonder if Prow can do PRs itself ? 🤔

Agreed, that's really something that we are missing, some kind of label to automate backport to n-x branches

Copy link
Member

@MrFreezeex MrFreezeex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 22, 2024
@MrFreezeex
Copy link
Member

MrFreezeex commented Jan 22, 2024

We should most likely have a way to track backport but not sure if it would be sufficient here as there is a different default k8s version for each branch 🤔.

@mzaian
Copy link
Contributor

mzaian commented Jan 22, 2024

I would say we should not be adding those hashes to prior releases If no CVEs or security related fixes. Or At least we supply them to 1 older release.

Copy link
Contributor

@mzaian mzaian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MrFreezeex, mzaian, VannTen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 22, 2024
@k8s-ci-robot k8s-ci-robot merged commit e14ab33 into kubernetes-sigs:release-2.22 Jan 22, 2024
62 checks passed
@VannTen VannTen mentioned this pull request Feb 5, 2024
@@ -0,0 +1,3 @@
---
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@VannTen Hello, may I ask if this file is redundant? The actual checksum information is stored in the roles/download/defaults/main.yml file. I'm not quite sure what the purpose of this new file is.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hum, yeah, not sure how this got there. 🤔

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😊Do you have time to verify if this file is useless? If it is, I suggest removing it. Thank you very much.🤝

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hum it does not appear to be in release-2.22 though.. 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants