-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[apiserver-kubelet/tracing]: add distributed tracing config variables #10795
[apiserver-kubelet/tracing]: add distributed tracing config variables #10795
Conversation
Signed-off-by: Ugur Ozturk <ugurozturk918@gmail.com>
Hi @ugur99. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As we're dropping 1.26 support from master, no need to support it.
Also I think you're release should separate kubelet and kube_apiserver tracing entry
If I understand the doc correctly, the two features are independent from each other.
Signed-off-by: Ugur Ozturk <ugurozturk918@gmail.com>
Signed-off-by: Ugur Ozturk <ugurozturk918@gmail.com>
Hi @VannTen thank you for the looking at this. Ah sure; I fixed it.
Yes, there is no dependency between them.
Sure, how can I do that? Would splitting the release notes into two lines work?
|
Yeah two lines are fine ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot @ugur99
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mzaian, ugur99 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…kubernetes-sigs#10795) * [apiserver-kubelet/tracing]: add distributed tracing config flags Signed-off-by: Ugur Ozturk <ugurozturk918@gmail.com> * [apiserver-kubelet/tracing]: add distributed tracing config flags - fix Signed-off-by: Ugur Ozturk <ugurozturk918@gmail.com> * [apiserver-kubelet/tracing]: add distributed tracing config flags - fix Signed-off-by: Ugur Ozturk <ugurozturk918@gmail.com> --------- Signed-off-by: Ugur Ozturk <ugurozturk918@gmail.com>
What type of PR is this?
/kind feature
What this PR does / why we need it:
This MR contains some enhancements that make possible to enable distributed tracing for
kubelet
andkube-apiserver
components.Which issue(s) this PR fixes:
Fixes # none
Special notes for your reviewer:
APIServerTracing
andKubeletTracing
have been graduated to beta version with v1.27.Refs:
Does this PR introduce a user-facing change?: