workaround for terraform bug related to no_floating and extra_groups

[rptaylor]

What type of PR is this?

/kind bug

What this PR does / why we need it:
Using ! instead of == false avoids the problem described in the linked issue and is probably better practice for boolean comparison anyway.

Which issue(s) this PR fixes:
Fixes #10763

Special notes for your reviewer:
I tested if floating_ip is true, no_floating is removed:

~ "kubespray_groups" = "kube_node,k8s_cluster,no_floating,," -> "kube_node,k8s_cluster,,"

and adding an extra group works:

~ "kubespray_groups" = "kube_node,k8s_cluster,no_floating,," -> "kube_node,k8s_cluster,,floaty_node"

Also if floating_ip is false, the no_floating group remains as expected, and if an extra group is added it fixes the bug:

~ "kubespray_groups" = "kube_node,k8s_cluster,no_floating,," -> "kube_node,k8s_cluster,no_floating,,gpu_node"

So in all cases this has the expected result.

Does this PR introduce a user-facing change?:

Workaround for terraform bug related to no_floating and extra_groups

[k8s-ci-robot]

Hi @rptaylor. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[yankay]

Thanks @rptaylor
/lgtm
/ok-to-test

[rptaylor]

/assign holmsten

[rptaylor]

The tests are passing, can you please have a look and approve it @holmsten or @mzaian ?

[floryut]

@rptaylor lgtm, thank you 👍

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floryut, rptaylor

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• contrib/terraform/OWNERS [floryut]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment