-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add dnsPolicy: ClusterFirstWithHostNet to DaemonSets with hostNetwork: true #10618
add dnsPolicy: ClusterFirstWithHostNet to DaemonSets with hostNetwork: true #10618
Conversation
Hi @Payback159. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
Hello @Payback159 Can you check the failed jobs errors. |
…: true value to avoid DNSConfigFormat events
7399b60
to
b660fdf
Compare
Hi @mzaian, CI now seems to be running successfully. The problem was the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Payback159
/cc @yankay
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mzaian, Payback159 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thanks @Payback159 |
…: true value to avoid DNSConfigFormat events (kubernetes-sigs#10618)
What type of PR is this?
/kind bug
What this PR does / why we need it:
add
dnsPolicy: ClusterFirstWithHostNet
to DaemonSets withhostNetwork: true
value to avoid DNSConfigFormat events. Since DaemonSets also scale with the number of nodes, this can quickly result in many DNSConfigFormat events.Which issue(s) this PR fixes:
Fixes #10604
Special notes for your reviewer:
add dnsPolicy: ClusterFirstWithHostNet to DaemonSets with hostNetwork: true value to avoid DNSConfigFormat events
Does this PR introduce a user-facing change?: