-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
terraform-aws: variable driven ami selection #10520
terraform-aws: variable driven ami selection #10520
Conversation
Welcome @mertcancam! |
Hi @mertcancam. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
a4bc4ad
to
2a8c39b
Compare
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mertcancam Thank you 👍
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: floryut, mertcancam The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thanks @mertcancam |
* modify variables.tf to accept AMI attributes via variables * update README to guide users on utilizing variable-driven AMI configuration * fix markdown lint error
* modify variables.tf to accept AMI attributes via variables * update README to guide users on utilizing variable-driven AMI configuration * fix markdown lint error
* modify variables.tf to accept AMI attributes via variables * update README to guide users on utilizing variable-driven AMI configuration * fix markdown lint error
* modify variables.tf to accept AMI attributes via variables * update README to guide users on utilizing variable-driven AMI configuration * fix markdown lint error
What type of PR is this?
What this PR does / why we need it:
This PR enhances the AMI selection mechanism by making it variable-driven, enabling users to specify AMI filters directly through variables, thereby improving usability and customization. It aims to provide more flexibility to the users in selecting various AMIs for different distributions without altering the main Terraform files.
ami_name_pattern
,ami_owners
andami_virtualization_type
through variables, enhancing configurability.Which issue(s) this PR fixes:
Special notes for reviewers:
The
variables.tf
file is modified to acceptami_name_pattern
,ami_owners
andami_virtualization_type
as variables, ensuring that users can specify their preferred AMI without altering main files. This change is backward compatible as it keeps default values in line with the existing hardcoded configuration, ensuring no disruption for users who wish to continue using the existing method.The README has been updated to reflect these changes and guide users on how to apply them. It provides examples and outlines the step-by-step method for specifying AMI attributes through variables.
Your feedback and insights regarding this implementation and its impact on the user experience would be highly valued.
Does this PR introduce a user-facing change?: