Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[etcd] make etcd 3.5.9 default #10482

Merged
merged 1 commit into from
Sep 29, 2023
Merged

[etcd] make etcd 3.5.9 default #10482

merged 1 commit into from
Sep 29, 2023

Conversation

mzaian
Copy link
Contributor

@mzaian mzaian commented Sep 26, 2023

What type of PR is this?

/kind feature

What this PR does / why we need it:

etcd 3.5.9 is default for the k8s v1.26 v1.27 1.28 releases.

The new version is already in the respective branches for these releases. Previous etcd versions contains High CVEs. See the discussion here: kubernetes/kubernetes#117648

Does this PR introduce a user-facing change?:

[etcd] Default version to 3.5.9 for k8s 1.28 , 1.27 , 1.26

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 26, 2023
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 26, 2023
floryut
floryut approved these changes Sep 29, 2023
View reviewed changes
Copy link
Member

@floryut floryut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mzaian All good checked and default to 3.5.9 🍻
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 29, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floryut, MrFreezeex, mzaian

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 4846f33 into kubernetes-sigs:master Sep 29, 2023
61 checks passed
guytet pushed a commit to guytet/kubespray that referenced this pull request Oct 30, 2023
@mzaian
[etcd] make etcd 3.5.9 default (kubernetes-sigs#10482)
3a8d19f
@yankay yankay mentioned this pull request Dec 15, 2023
Closed
pedro-peter pushed a commit to pedro-peter/kubespray that referenced this pull request May 8, 2024
@mzaian @pedromcpedro
[etcd] make etcd 3.5.9 default (kubernetes-sigs#10482)
a32eb1c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@floryut floryut floryut approved these changes

@MrFreezeex MrFreezeex MrFreezeex approved these changes

@cyclinder cyclinder Awaiting requested review from cyclinder

Assignees

@floryut floryut

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mzaian @k8s-ci-robot @MrFreezeex @floryut