Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Retry for Applying PriorityClass #10469

Merged

Conversation

hangscer8
Copy link
Member

@hangscer8 hangscer8 commented Sep 22, 2023

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

/kind bug

What this PR does / why we need it:

  • Retry to make applying PriorityClass more stable. I found the follwing log:
4:23PM: TASK [kubernetes-apps/cluster_roles : PriorityClass | Create k8s-cluster-critical] ***
4:23PM: fatal: [poc-master3]: FAILED! => {"changed": false, "msg": "error running kubectl (/usr/local/bin/kubectl apply --force --filename=/etc/kubernetes/k8s-cluster-critical-pc.yml) command (rc=1), out='', err='Error from server (Timeout): error when retrieving current configuration of:\nResource: \"scheduling.k8s.io/v1, Resource=priorityclasses\", GroupVersionKind: \"scheduling.k8s.io/v1, Kind=PriorityClass\"\nName: \"k8s-cluster-critical\", Namespace: \"\"\nfrom server for: \"/etc/kubernetes/k8s-cluster-critical-pc.yml\": the server was unable to return a response in the time allotted, but may still be processing the request (get priorityclasses.scheduling.k8s.io k8s-cluster-critical)\n'"}

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Add Retry for Applying PriorityClass

Signed-off-by: hang.jiang <hang.jiang@daocloud.io>
@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 22, 2023
@floryut floryut added kind/feature Categorizes issue or PR as related to a new feature. and removed kind/bug Categorizes issue or PR as related to a bug. labels Sep 22, 2023
Copy link
Member

@floryut floryut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hangscer8 Thank you for the PR 👍

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floryut, hangscer8

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 22, 2023
@yankay
Copy link
Member

yankay commented Sep 25, 2023

Thanks
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 25, 2023
@k8s-ci-robot k8s-ci-robot merged commit c6ab640 into kubernetes-sigs:master Sep 25, 2023
62 checks passed
guytet pushed a commit to guytet/kubespray that referenced this pull request Oct 30, 2023
Signed-off-by: hang.jiang <hang.jiang@daocloud.io>
@yankay yankay mentioned this pull request Dec 15, 2023
pedro-peter pushed a commit to pedro-peter/kubespray that referenced this pull request May 8, 2024
Signed-off-by: hang.jiang <hang.jiang@daocloud.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants