-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable configuring mountOptions, reclaimPolicy and volumeBindingMode … #10450
Enable configuring mountOptions, reclaimPolicy and volumeBindingMode … #10450
Conversation
…for cinder-csi StorageClasses
Hi @Payback159. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
roles/kubernetes-apps/persistent_volumes/openstack/templates/openstack-storage-class.yml.j2
Show resolved
Hide resolved
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
Looks OK to me |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Payback159 Thank you and sorry about the delay
lgtm also 👍
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: floryut, Payback159 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubernetes-sigs#10450) * Enable configuring mountOptions, reclaimPolicy and volumeBindingMode for cinder-csi StorageClasses * Check if class.mount_options is defined at all, before generating the option list
…for cinder-csi StorageClasses
What type of PR is this?
/kind feature
What this PR does / why we need it:
Enable configuring mountOptions, reclaimPolicy and volumeBindingMode for cinder-csi StorageClasses. Depending on the environment, it may be necessary to assign certain mountOptions, e.g. "discard" to enable trimming of volumes. reclaimPolicy to enable automatic cleanups of PersistentVolumes and to define the binding behavior of PersistentVolumes.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: