-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix youki binary download url #10337
Conversation
Signed-off-by: bo.jiang <bo.jiang@daocloud.io>
Thanks @ErikJiang |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ErikJiang Great thank you
Thanks @ErikJiang |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ErikJiang, yankay The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I think we need to tweak |
I am so sorry for noticing it this late. # roles/download/defaults/main/main.yml
youki_download_url: "https://github.com/containers/youki/releases/download/v{{ youki_version }}/youki_{{ 'v' if youki_version == '0.0.1' else '' }}{{ youki_version | regex_replace('\\.', '_') }}_linux.tar.gz" Though this being a problem is highly unlikely, I'll just leave this here in case a bug is reported by someone. |
I think we would only need a 2-3 working version of |
Signed-off-by: bo.jiang <bo.jiang@daocloud.io>
What type of PR is this?
/kind bug
What this PR does / why we need it:
The Youki binary download URL is not valid, it needs to remove the unnecessary 'v' character.
Which issue(s) this PR fixes:
Fixes #10331
Special notes for your reviewer:
Does this PR introduce a user-facing change?: