Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix youki binary download url #10337

Merged
merged 1 commit into from
Aug 8, 2023
Merged

Fix youki binary download url #10337

merged 1 commit into from
Aug 8, 2023

Conversation

ErikJiang
Copy link
Member

@ErikJiang ErikJiang commented Aug 4, 2023

What type of PR is this?
/kind bug

What this PR does / why we need it:

The Youki binary download URL is not valid, it needs to remove the unnecessary 'v' character.

- https://github.com/containers/youki/releases/download/v0.1.0/youki_v0_1_0_linux.tar.gz
+ https://github.com/containers/youki/releases/download/v0.1.0/youki_0_1_0_linux.tar.gz

Which issue(s) this PR fixes:

Fixes #10331

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Fix youki binary download url (not requiring 'v' in version)

Signed-off-by: bo.jiang <bo.jiang@daocloud.io>
@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 4, 2023
@mzaian
Copy link
Contributor

mzaian commented Aug 4, 2023

Thanks @ErikJiang
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 4, 2023
Copy link
Member

@floryut floryut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ErikJiang Great thank you

@yankay
Copy link
Member

yankay commented Aug 8, 2023

Thanks @ErikJiang
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ErikJiang, yankay

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 8, 2023
@MrFreezeex
Copy link
Member

I think we need to tweak scripts/download_hash.sh as well so that it don't break again next time we use this script

@k8s-ci-robot k8s-ci-robot merged commit 2fbbb70 into kubernetes-sigs:master Aug 8, 2023
59 checks passed
@mrafee113
Copy link

I am so sorry for noticing it this late.
According to the youki github release page, the url of the first release of youki 0.0.1 is like v_0_0_1.
Therefore (e.g.):

# roles/download/defaults/main/main.yml
youki_download_url: "https://github.com/containers/youki/releases/download/v{{ youki_version }}/youki_{{ 'v' if youki_version == '0.0.1' else '' }}{{ youki_version | regex_replace('\\.', '_') }}_linux.tar.gz"

Though this being a problem is highly unlikely, I'll just leave this here in case a bug is reported by someone.

@mzaian
Copy link
Contributor

mzaian commented Aug 14, 2023

I am so sorry for noticing it this late. According to the youki github release page, the url of the first release of youki 0.0.1 is like v_0_0_1. Therefore (e.g.):

# roles/download/defaults/main/main.yml
youki_download_url: "https://github.com/containers/youki/releases/download/v{{ youki_version }}/youki_{{ 'v' if youki_version == '0.0.1' else '' }}{{ youki_version | regex_replace('\\.', '_') }}_linux.tar.gz"

Though this being a problem is highly unlikely, I'll just leave this here in case a bug is reported by someone.

I think we would only need a 2-3 working version of youki so no need to look at very old releases anyway.

@yankay yankay mentioned this pull request Aug 24, 2023
pedro-peter pushed a commit to pedro-peter/kubespray that referenced this pull request May 8, 2024
Signed-off-by: bo.jiang <bo.jiang@daocloud.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

youki default url is wrong
7 participants