Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

link update for aws_alb_ingress_controller #10264

Merged

Conversation

kundan2707
Copy link
Contributor

@kundan2707 kundan2707 commented Jun 28, 2023

What type of PR is this?
/kind documentation

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #10263

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Update links for aws_alb_ingress_controller

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 28, 2023
@yankay
Copy link
Member

yankay commented Jun 29, 2023

Thanks @kundan2707

/lgtm

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. and removed cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 29, 2023
Copy link
Member

@floryut floryut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kundan2707 Thank you for the PR 👍
/ok-to-test
/check-cla

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Jun 30, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floryut, kundan2707

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 30, 2023
@MrFreezeex
Copy link
Member

MrFreezeex commented Jul 3, 2023

Hi @kundan2707 could you check the CNCF CLA by clickling on details in the (failed) step "EasyCLA" of the CI and possibly sign it? Your PR should be merged after that you signed it (and that the CI actually notices it) 🙏.

@kundan2707
Copy link
Contributor Author

@MrFreezeex i have completed all steps still it show cncf-cla:no

@MrFreezeex
Copy link
Member

/check-cla
/easycla

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jul 3, 2023
@k8s-ci-robot k8s-ci-robot merged commit f8b93fa into kubernetes-sigs:master Jul 3, 2023
@floryut floryut added the kind/documentation Categorizes issue or PR as related to documentation. label Jul 18, 2023
@yankay yankay mentioned this pull request Aug 24, 2023
pedro-peter pushed a commit to pedro-peter/kubespray that referenced this pull request May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
5 participants