-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix gce-pd-csi driver #10208
fix gce-pd-csi driver #10208
Conversation
Hi @ashishsinghdev. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@MrFreezeex Could you please have a quick look? Tested on GCP, working fluently with these changes. https://snipboard.io/i4VjnQ.jpg |
Hi, thanks, it looks very good 🙏 ❤️! You just need to update the version in the README of |
roles/kubernetes-apps/csi_driver/gcp_pd/templates/gcp-pd-csi-controller.yml.j2
Outdated
Show resolved
Hide resolved
…gcp-pd-csi driver version in README.md
Done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, your contribution is much appreciated 🙏
/lgtm
/ok-to-test
/assign @LuckySB |
Thanks @ashishsinghdev for update /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ashishsinghdev, MrFreezeex, yankay The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* fix gce-pd-csi driver * fixed, 1. reading replicas value from defaults.yml, and 2. corrected gcp-pd-csi driver version in README.md
* fix gce-pd-csi driver * fixed, 1. reading replicas value from defaults.yml, and 2. corrected gcp-pd-csi driver version in README.md
What type of PR is this?
/kind bug
What this PR does / why we need it:
Fixes below mentioned issues:
In release version v2.22.0/1, gce-pde-csi driver is not working due to below mentioned reasons.
Old gce-pd-csi driver version
Missing Kind: CSIDriver in current manifests files, which is required to run external CSI driver in Kubernetes version 1.18+
Need to sync manifests from original gce-pd csi driver repo, https://github.com/kubernetes-sigs/gcp-compute-persistent-disk-csi-driver
Which issue(s) this PR fixes:
Fixes #10207
Special notes for your reviewer:
Does this PR introduce a user-facing change?: