-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump coredns version to 1.10.1 #10199
Conversation
Hi @eminaktas. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@eminaktas Thank you!
I'm putting a hold, as we might want to wait for 1.27 switch, WDYT ?
On the other hand as long as CI works, no need to wait I guess.
/hold
Thanks. CI failed :(. I'll take a look 👍 |
/retest |
@eminaktas: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
d77fe2e
to
4af8bd9
Compare
When I checked the logs nodelocaldns was not able to reach coredns. [ERROR] plugin/errors: 2 netchecker-service.cluster.local. AAAA: dial tcp 10.233.0.3:53: connect: connection refused
[ERROR] plugin/errors: 2 netchecker-service.cluster.local. A: dial tcp 10.233.0.3:53: connect: connection refused
[ERROR] plugin/errors: 2 netchecker-service.cluster.local. AAAA: dial tcp 10.233.0.3:53: connect: connection refused
[ERROR] plugin/errors: 2 netchecker-service.894123319-4440306518.svc.cluster.local. A: dial tcp 10.233.0.3:53: connect: connection refused
[ERROR] plugin/errors: 2 netchecker-service.894123319-4440306518.svc.cluster.local. AAAA: dial tcp 10.233.0.3:53: connect: connection refused
[ERROR] plugin/errors: 2 netchecker-service.894123319-4440306518.svc.cluster.local. A: dial tcp 10.233.0.3:53: connect: connection refused
[ERROR] plugin/errors: 2 netchecker-service.894123319-4440306518.svc.cluster.local. AAAA: dial tcp 10.233.0.3:53: connect: connection refused However, coredns pods look healthy and in the running state. TASK [Check connectivity with all netchecker agents] ***************************
task path: /builds/kargo-ci/kubernetes-sigs-kubespray/tests/testcases/040_check-network-adv.yml:157
Thursday 08 June 2023 18:10:04 +0000 (0:00:00.199) 0:03:20.301 *********
fatal: [instance-2 -> instance-1(172.30.76.118)]: FAILED! => {
"assertion": "agents_check_result is defined",
"changed": false,
"evaluated_to": false,
"msg": "Connectivity check to netchecker agents failed"
} |
/ok-to-test |
Signed-off-by: Emin Aktaş <eminaktas34@gmail.com>
4af8bd9
to
3929187
Compare
Hey @floryut, I think it is ok to merge now. 👀 |
Fine for me, as long as someone lgtm this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution 👍!
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: eminaktas, floryut, MrFreezeex The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Emin Aktaş <eminaktas34@gmail.com>
Signed-off-by: Emin Aktaş <eminaktas34@gmail.com>
What type of PR is this?
/kind feature
What this PR does / why we need it:
bumps coredns default version to 1.10.1
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: