-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix missing newline in template which breaks nginx-ingress deployment #10174
fix missing newline in template which breaks nginx-ingress deployment #10174
Conversation
|
Welcome @richard-fairthorne! |
Hi @richard-fairthorne. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: oomichi, richard-fairthorne The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
What type of PR is this?
/kind bug
What this PR does / why we need it:
This fixes a missing newline which prevents nginxingress-class from deploying, and aborts the deployment script.
Which issue(s) this PR fixes:
Unable to deploy nginxingress-class.yml IF nginx is default class. (This is due to a missing newline in the jinja template)
Fixes #10173
Special notes for your reviewer:
Does this PR introduce a user-facing change?: