-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add node_taints to aws_inventory script (#10168) #10170
Add node_taints to aws_inventory script (#10168) #10170
Conversation
|
Welcome @mstoetzer! |
Hi @mstoetzer. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need to fix aws.md to pass the ci job.
Thanks @mstoetzer /lgtm |
Thanks for fixing the issue. /ok-to-test |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mstoetzer, oomichi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Allows to add
node_taints
to be added to the ec2 instance tags.Which issue(s) this PR fixes:
Fixes #10168
Special notes for your reviewer:
The last change to the aws_inventory script has been long time ago.
REGION
environment variable is also deprecated and has been renamed toAWS_REGION
.Does this PR introduce a user-facing change?: