cert-manager controller args:

[phunyguy]

• Adding in the ability to feed extra-args to cert-manager-controller.

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test

/kind feature

/kind flake

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

This introduces a new variable for the cert-manager implementation that will allow one to pass in extra arguments to the cert-manager controller.
cert_manager_controller_extra_args

An example variable declaration would be:
cert_manager_controller_extra_args:
  - "--dns01-recursive-nameservers-only=true"
  - "--dns01-recursive-nameservers=1.1.1.1:53,8.8.8.8:53"

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: phunyguy / name: Rob Tongue (cd9bf4f)

[k8s-ci-robot]

Welcome @phunyguy!

It looks like this is your first PR to kubernetes-sigs/kubespray 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kubespray has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @phunyguy. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[floryut]

@phunyguy Thank you for the PR, could you check the fail

"AnsibleUndefinedVariable: 'cert_manager_controller_extra_args' is undefined"

I was going to say that you should add a check for undefined var but the job catch it first ;)

[phunyguy]

@phunyguy Thank you for the PR, could you check the fail

"AnsibleUndefinedVariable: 'cert_manager_controller_extra_args' is undefined"

I was going to say that you should add a check for undefined var but the job catch it first ;)

Yep... Silly move on my part, I know better. I'll fix it up.

[phunyguy]

I was going to say that you should add a check for undefined var but the job catch it first ;)

@floryut It looks like on a rerun there was an unrelated error. Is there something else I should be doing here?

[MrFreezeex]

Hi quick nits, could you rather default this new var to empty array in roles/kubernetes-apps/ingress_controller/cert_manager/defaults/main.yml, apart from that lgtm. Thanks!

[MrFreezeex]

Also for the CI to work please rebase the PR, apart from that it's unfortunately a matter of if you're lucky or not (or rather the CI is not running too many tasks at once)...

[MrFreezeex]

Hi! Last thing could you squash your commits? Apart from that looks good :)!

[phunyguy]

Hi! Last thing could you squash your commits? Apart from that looks good :)!

I think I figured that out. Still new to this. Thanks for the feedback!

[oomichi]

Thanks for doing this.

/ok-to-test
/approve

[oomichi]

Could you rebase this pull request on the latest master branch?
#10099 which fixes tf-elastx_cleanup failure seems missing on this pull request branch.

[MrFreezeex]

Thanks for the contribution! Next time you should use git fetch origin && git rebase origin master instead of git merge to pull latest changes from master but as we squash while merging should be fine this time, let's not wait for another CI run IMO.
/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MrFreezeex, oomichi, phunyguy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [oomichi]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment