Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Metadata section for external-openstack-cloud-config's cloud.conf in templates #6338

Closed
Sryther opened this issue Jun 29, 2020 · 0 comments · Fixed by #6339
Closed

Add Metadata section for external-openstack-cloud-config's cloud.conf in templates #6338

Sryther opened this issue Jun 29, 2020 · 0 comments · Fixed by #6339
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@Sryther
Copy link
Contributor

Sryther commented Jun 29, 2020 •
edited
Loading

What would you like to be added:

The "Metadata" parameters section in the template roles/kubernetes-apps/external_cloud_controller/openstack/templates/external-openstack-cloud-config.j2.

The content to add would look like this:

[Metadata]
search-order=configDrive,metadataService

The default values (previous example) could be changed in inventory/mycluster/group_vars/all/openstack.yml.

This is handled by kubernetes/cloud-provider-openstack since the v.14 (doc).

Documentation: https://github.com/kubernetes/cloud-provider-openstack/blob/master/docs/using-openstack-cloud-controller-manager.md#metadata

Why is this needed:

I encountered issues in a fresh install, when I would attach automatically a volume to pod, the instance where the pod was couldn't be found. The id used for the instance wasn't the right one because the CSI plugin wasn't using the id given by Openstack.

Without this improvement we have extra steps to configure the cluster while we think it'll work seamlessly.
@Sryther Sryther added the kind/feature Categorizes issue or PR as related to a new feature. label Jun 29, 2020
@Sryther Sryther mentioned this issue Jun 29, 2020
Merged
Sryther added a commit to Sryther/kubespray that referenced this issue Jul 1, 2020
@Sryther
Add additional metadata configuration option to external Openstack CCM (
8144b2f 
kubernetes-sigs#6338)
k8s-ci-robot pushed a commit that referenced this issue Jul 1, 2020
@Sryther
Add additional metadata configuration options to external Openstack C…
bcac3c6 
…CM (#6338) (#6339)

* Add additional metadata configuration option to external Openstack CCM (#6338)

* Set the variable external_openstack_metadata_search_order undefined by default
erulabs added a commit to kubesail/kubespray that referenced this issue Jul 1, 2020
@erulabs
Merge branch 'master' of https://github.com/kubernetes-sigs/kubespray
afae4dc 
* 'master' of https://github.com/kubernetes-sigs/kubespray:
  Patch Calico for V3.14.0 missing CR and CRD (kubernetes-sigs#6276)
  Explicitly set ETCDCTL_API and use ETCDCTL_ENDPOINTS (kubernetes-sigs#6327)
  Add additional metadata configuration options to external Openstack CCM (kubernetes-sigs#6338) (kubernetes-sigs#6339)
LuckySB pushed a commit to southbridgeio/kubespray that referenced this issue Sep 16, 2020
@Sryther @LuckySB
Add additional metadata configuration options to external Openstack C…
5c96147 
…CM (kubernetes-sigs#6338) (kubernetes-sigs#6339)

* Add additional metadata configuration option to external Openstack CCM (kubernetes-sigs#6338)

* Set the variable external_openstack_metadata_search_order undefined by default
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Milestone
No milestone
1 participant
@Sryther