Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Network section for external-openstack-cloud-config's cloud.conf in templates #6083

Closed
Sryther opened this issue May 6, 2020 · 2 comments · Fixed by #6085
Closed

Add Network section for external-openstack-cloud-config's cloud.conf in templates #6083

Sryther opened this issue May 6, 2020 · 2 comments · Fixed by #6085
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@Sryther
Copy link
Contributor

Sryther commented May 6, 2020

What would you like to be added:

The "Network" parameters section in the template roles/kubernetes-apps/external_cloud_controller/openstack/templates/external-openstack-cloud-config.j2.

The content to add would look like this:

[Networking]
ipv6-support-disabled=false
internal-network-name=""
public-network-name=""

The default values could be changed in inventory/mycluster/group_vars/all/openstack.yml.

This is handled by kubernetes/cloud-provider-openstack since the v.14 (doc)

Documentation: https://github.com/kubernetes/cloud-provider-openstack/blob/master/docs/using-openstack-cloud-controller-manager.md#networking

Why is this needed:

I encountered issues in a fresh install with calico-node not being able to discover nodes because the Internal IP of nodes was provisioned wrongly by the DaemonSet openstack-cloud-controller-manager.

The addresses given to the nodes was simply all the IPs from OpenStack (public, private and IPv6 addresses) while we want only the true internal IPs.

After adding manually the Network section in the external-openstack-cloud-config Secret and reloading the openstack-cloud-controller-manager, the nodes had the right Internal IPs in their Addresses.

Without this improvement we have extra steps to configure the cluster while we think it'll work seamlessly.

Sorry for my english :)

@Sryther Sryther added the kind/feature Categorizes issue or PR as related to a new feature. label May 6, 2020
@floryut
Copy link
Member

floryut commented May 6, 2020

@Sryther Thanks for finding this, are you available to submit a PR ?

@Sryther
Copy link
Contributor Author

Sryther commented May 6, 2020

This issue (cloud-provider-openstack/issues/407) is related to what could happen if we omit this configuration.

k8s-ci-robot pushed a commit that referenced this issue May 18, 2020
#6083) (#6085)

* Add additional network configuration options to external Openstack CCM (#6083)

* Change the default version of external openstack cloud controller image to v1.18.1 since there was an issue in v1.18.0 where some IPs of the private network were ignored

* Change Network section in external-openstack-cloud-config.j2 to Networking

* Add networking customization information in the openstack documentation
LuckySB pushed a commit to southbridgeio/kubespray that referenced this issue May 29, 2020
kubernetes-sigs#6083) (kubernetes-sigs#6085)

* Add additional network configuration options to external Openstack CCM (kubernetes-sigs#6083)

* Change the default version of external openstack cloud controller image to v1.18.1 since there was an issue in v1.18.0 where some IPs of the private network were ignored

* Change Network section in external-openstack-cloud-config.j2 to Networking

* Add networking customization information in the openstack documentation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants