Skip to content

Conversation

camilamacedo86
Copy link
Member

@camilamacedo86 camilamacedo86 commented Aug 19, 2025

Why are we reverting the scaffold changes?

Thank you to the original author for their contribution. This change is being made to ensure project stability for all users.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 19, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested a review from Kavinjsir August 19, 2025 10:08
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 19, 2025
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 19, 2025
- --leader-elect
- --health-probe-bind-address=:8081
image: controller:latest
imagePullPolicy: IfNotPresent
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adarshagrawal38

Hey I'm going to revert the changes in the default scaffold, and here's why.

I know I suggested this earlier, but after thinking it through, I realized it's not the best option. Changes to the stable default scaffold can't be done lightly because they can cause a lot of issues for users when they upgrade.

Adding all possible values and defaults would also make things very complex and hard, and bring confusion, seems like an anti pattern.

Ultimately, we need a better, more maintainable approach for our Helm charts plugin. See these links for more context:

I haven't had time to think of a solution, but I want to avoid making a change that creates more work for our users when they upgrade. If you have time, please feel free to look at these requirements and think about how we could address them in a better way.

Again, thank you so much for your contribution. I really appreciate your help.

@camilamacedo86 camilamacedo86 changed the title 🐛 (revert) changes done in the default scaffold in the pr: 4932 🐛 (revert) only changes done in the default scaffold in the pr: 4932 ( kept helm chart changes ) Aug 19, 2025
@camilamacedo86 camilamacedo86 added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 19, 2025
@k8s-ci-robot k8s-ci-robot merged commit 79a817b into kubernetes-sigs:master Aug 19, 2025
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants