Skip to content

Conversation

camilamacedo86
Copy link
Member

Reverts #4992

After more tests we realized that is not needed reverting it

…uns post-merge fixes in best-effort mode raising warnings instead of errors to allow properly automation with this option"
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 7, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 7, 2025
@vitorfloriano
Copy link
Contributor

I ran a test with this PR and got this:

INFO Preparing Merge branch and performing merge branch_name=tmp-merge-07-08-25-18-53
WARN Merge completed with conflicts. Conflict markers will be committed.
INFO Running make manifests command=make manifests
Makefile:75: *** missing separator.  Stop.
WARN make target failed target=manifestserror=error running "make": exit status 2
INFO Running make generate command=make generate
Makefile:75: *** missing separator.  Stop.
WARN make target failed target=generateerror=error running "make": exit status 2
INFO Running make fmt command=make fmt
Makefile:75: *** missing separator.  Stop.
WARN make target failed target=fmterror=error running "make": exit status 2
INFO Running make vet command=make vet
Makefile:75: *** missing separator.  Stop.
WARN make target failed target=veterror=error running "make": exit status 2
INFO Running make lint-fix command=make lint-fix
Makefile:75: *** missing separator.  Stop.
WARN make target failed target=lint-fixerror=error running "make": exit status 2

So the changes were reverted, as intended.

/lgtm

@k8s-ci-robot
Copy link
Contributor

@vitorfloriano: changing LGTM is restricted to collaborators

In response to this:

I ran a test with this PR and got this:

INFO Preparing Merge branch and performing merge branch_name=tmp-merge-07-08-25-18-53
WARN Merge completed with conflicts. Conflict markers will be committed.
INFO Running make manifests command=make manifests
Makefile:75: *** missing separator.  Stop.
WARN make target failed target=manifestserror=error running "make": exit status 2
INFO Running make generate command=make generate
Makefile:75: *** missing separator.  Stop.
WARN make target failed target=generateerror=error running "make": exit status 2
INFO Running make fmt command=make fmt
Makefile:75: *** missing separator.  Stop.
WARN make target failed target=fmterror=error running "make": exit status 2
INFO Running make vet command=make vet
Makefile:75: *** missing separator.  Stop.
WARN make target failed target=veterror=error running "make": exit status 2
INFO Running make lint-fix command=make lint-fix
Makefile:75: *** missing separator.  Stop.
WARN make target failed target=lint-fixerror=error running "make": exit status 2

So the changes were reverted, as intended.

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@camilamacedo86 camilamacedo86 changed the title Revert "🐛 (alpha commands): alpha update command with --force now runs post-merge fixes in best-effort mode raising warnings instead of errors to allow properly automation with this option" 🌱 Revert "🐛 (alpha commands): alpha update command with --force now runs post-merge fixes in best-effort mode raising warnings instead of errors to allow properly automation with this option" Aug 8, 2025
@camilamacedo86 camilamacedo86 added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 8, 2025
@k8s-ci-robot k8s-ci-robot merged commit 7d208b7 into master Aug 8, 2025
26 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants