Skip to content

Conversation

mayuka-c
Copy link
Contributor

@mayuka-c mayuka-c commented Jul 29, 2025

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 29, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @mayuka-c. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 29, 2025
arch="i686"
elif [[ ${arch} == "arm64" ]]; then
arch="aarch64"
fi
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like updating mdbook to latest version was causing this issue, as the latest Netlify build images does not have latest required GLIBC version. Have reverted back to v0.4.40. Now it has passed.

Also I had to change arch to use x86_64 as it is the only archType available for Darwin: https://github.com/rust-lang/mdBook/releases/tag/v0.4.40.

Revert mdbook to v0.4.40

Add comment
@camilamacedo86 camilamacedo86 changed the title 🐛 Docs: Install-and-build.sh script fixes and enhancements 🌱 (fix) Install-and-build.sh script to work on MacOs Jul 29, 2025
Copy link
Member

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approved

Thank you 🥇
Note: I hope that you do not mind, see that I update the title because we use the title for release notes
In this case, the change does not affect users, so they cannot be 🐛 instead of 🌱 fit better.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 29, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86, mayuka-c

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 29, 2025
@camilamacedo86
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 29, 2025
@mayuka-c
Copy link
Contributor Author

/lgtm /approved

Thank you 🥇 Note: I hope that you do not mind, see that I update the title because we use the title for release notes In this case, the change does not affect users, so they cannot be 🐛 instead of 🌱 fit better.

Thank you so much for updating :-)

@k8s-ci-robot k8s-ci-robot merged commit 4ccac59 into kubernetes-sigs:master Jul 29, 2025
16 checks passed
@mayuka-c mayuka-c deleted the docs-install-fix branch July 29, 2025 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Docs: Install-and-build.sh script fails while installing mdbook on Mac

3 participants