-
Notifications
You must be signed in to change notification settings - Fork 1.6k
🌱 (fix) Install-and-build.sh script to work on MacOs #4970
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 (fix) Install-and-build.sh script to work on MacOs #4970
Conversation
Hi @mayuka-c. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
arch="i686" | ||
elif [[ ${arch} == "arm64" ]]; then | ||
arch="aarch64" | ||
fi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See: https://app.netlify.com/projects/kubebuilder/deploys/68883e1b2158da0008efc736
We can see that the changes broke the job.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like updating mdbook to latest version was causing this issue, as the latest Netlify build images does not have latest required GLIBC version. Have reverted back to v0.4.40
. Now it has passed.
Also I had to change arch to use x86_64 as it is the only archType available for Darwin: https://github.com/rust-lang/mdBook/releases/tag/v0.4.40.
2cfa357
to
110a8af
Compare
Revert mdbook to v0.4.40 Add comment
110a8af
to
00634e1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approved
Thank you 🥇
Note: I hope that you do not mind, see that I update the title because we use the title for release notes
In this case, the change does not affect users, so they cannot be 🐛 instead of 🌱 fit better.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86, mayuka-c The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/ok-to-test |
Thank you so much for updating :-) |
Uh oh!
There was an error while loading. Please reload this page.