✨ Upgrade Golang-CI from v2.1.6 to v2.2.2 #4945
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
camilamacedo86
commented
Jul 20, 2025
camilamacedo86
commented
- For Kubebuilder CLI and scaffolds
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
camilamacedo86
added
the
lgtm
k8s-ci-robot
added
size/L
camilamacedo86
force-pushed
the
upgrade-golangci
branch
from
804824f to
1c39c0f
Compare
k8s-ci-robot
added
size/M
camilamacedo86
force-pushed
the
upgrade-golangci
branch
from
0f3d730 to
9f8ee0a
Compare
k8s-ci-robot
added
size/M
camilamacedo86
force-pushed
the
upgrade-golangci
branch
from
9f8ee0a to
01964f2
Compare
k8s-ci-robot
added
size/L
camilamacedo86
force-pushed
the
upgrade-golangci
branch
2 times, most recently
from
b7c2268 to
510c4b0
Compare
k8s-ci-robot
added
size/M
|
/test pull-kubebuilder-e2e-k8s-1-33-0 |
|
/skip apidiff |
erikgb
reviewed
Jul 20, 2025
.golangci.yml
Outdated
| text: "should have comment or be unexported" | ||
| - linters: | ||
| - revive | ||
| text: "avoid meaningless package names" |
There was a problem hiding this comment.
Suggested change
| text: "avoid meaningless package names" | |
| text: "var-naming: avoid meaningless package names" |
To put some more context into this exclusion. But it would be even better if the revive linter is reconfigured instead, ref. https://golangci-lint.run/usage/linters/#revive
There was a problem hiding this comment.
Thank you 🥇🚀
I accept your suggestion, but I’m not sure how to reconfigure it myself. (I would need spend some time checking it out) Maybe we can add an issue in the repo, so I or someone else can check it out later and try to improve how it works.
There was a problem hiding this comment.
Please create an issue for it! Should be pretty straight forward, ref.
camilamacedo86
force-pushed
the
upgrade-golangci
branch
from
510c4b0 to
7e94203
Compare
k8s-ci-robot
added
the
lgtm
camilamacedo86
merged commit 6d91914
into
kubernetes-sigs:master
31 of 33 checks passed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.