-
Notifications
You must be signed in to change notification settings - Fork 1.6k
✨ (go/v4): Create API command now adds status conditions #4943
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ (go/v4): Create API command now adds status conditions #4943
Conversation
docs/book/src/multiversion-tutorial/testdata/project/api/v1/cronjob_types.go
Show resolved
Hide resolved
docs/book/src/multiversion-tutorial/testdata/project/api/v1/cronjob_types.go
Outdated
Show resolved
Hide resolved
c81201b
to
dc3b7c0
Compare
dc3b7c0
to
1dbc0ed
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice learning for me
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: afzal442, camilamacedo86 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
// {{ .Resource.Kind }}Status defines the observed state of {{ .Resource.Kind }}. | ||
type {{ .Resource.Kind }}Status struct { | ||
// INSERT ADDITIONAL STATUS FIELD - define observed state of cluster | ||
// Important: Run "make" to regenerate code after modifying this file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should doc be more explicit here?
// Important: Run "make" to regenerate code after modifying this file | |
// Important: Run "make generate manifests" to regenerate code after modifying this file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could we do it in a follow up?
Would you like to do this one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure, it can be follow up
Description
Now, when users run create api the following will also added by default
Motivation
To promote best practices in Kubernetes API development by including status conditions during resource scaffolding.
P.S.: Adapt tutorial generation hack scripts. In a follow-up, we should change the tutorial code to use the conditions and be more aligned with best practices, such as the deploy-image scaffold.