🌱 fix: centralize plugin key declaration

[mateusoliveira43]

Why the changes were made

Fix #4309

How the changes were made

Ran these commands to find occurrences

grep -Inr "base.go.kubebuilder.io" . --exclude=\*.{md,sh,toml}
grep -Inr "base/v4" . --exclude=\*.{md,sh,toml}
grep -Inr "deploy-image.go.kubebuilder.io" . --exclude=\*.{md,sh,toml}
grep -Inr "deploy-image/v1-alpha" . --exclude=\*.{md,sh,toml}
grep -Inr "grafana.kubebuilder.io" . --exclude=\*.{md,sh,toml}
grep -Inr "grafana/v1-alpha" . --exclude=\*.{md,sh,toml}
grep -Inr "helm.kubebuilder.io" . --exclude=\*.{md,sh,toml}
grep -Inr "helm/v1-alpha" . --exclude=\*.{md,sh,toml}
grep -Inr "kustomize.common.kubebuilder.io" . --exclude=\*.{md,sh,toml}
grep -Inr "kustomize/v2" . --exclude=\*.{md,sh,toml}
grep -Inr "sampleexternalplugin" . --exclude=\*.{md,sh,toml}
grep -Inr "sampleexternalplugin/v1" . --exclude=\*.{md,sh,toml}
grep -Inr "go.kubebuilder.io" . --exclude=\*.{md,sh,toml}
grep -Inr "go/v4" . --exclude=\*.{md,sh,toml}

ignoring test files.

Note: go.kubebuilder.io plugin is defined in cmd/main.go and could not change here because of import cycle

kubebuilder/pkg/plugins/golang/v4/scaffolds/init.go

Line 136 in 19237b5

gov4 := "go.kubebuilder.io/v4"

Note: could not change here because of import cycle

kubebuilder/pkg/plugins/golang/v4/scaffolds/internal/templates/readme.go

Line 61 in c32f971

codeFence(fmt.Sprintf("%s edit --plugins=helm/v1-alpha", f.CommandName)),

Note: did not find where sampleexternalplugin/v1 plugin key is defined to dynamically inject here https://github.com/kubernetes-sigs/kubebuilder/tree/c32f9714456f7e5e7cc6c790bb87c7e5956e710b/docs/book/src/simple-external-plugin-tutorial/testdata/sampleexternalplugin/v1/scaffolds

Note: did not change here

kubebuilder/pkg/plugins/golang/v4/init.go

Line 73 in c32f971

%[1]s init --plugins go/v4 --domain example.org --owner "Your name"

kubebuilder/pkg/plugins/golang/v4/init.go

Line 76 in c32f971

%[1]s init --plugins go/v4 --project-version 3

because of #4395

[k8s-ci-robot]

Hi @mateusoliveira43. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[mateusoliveira43]

separate PR, but deploy-image plugin folder should be v1alpha instead of v1alpha1?

[camilamacedo86]

To change that, we would break our APIs
So, let's keep it as it is until the day that we need to create another API and etc

[mateusoliveira43]

/hold saw that there multiple ways to call a plugin. Example: deploy-image/v1-alpha or deploy-image.go.kubebuilder.io/v1-alpha work for deploy-image plugin

[camilamacedo86]

/ok-to-test

[mateusoliveira43]

/unhold

[camilamacedo86]

I looked at the code it shows all fine 🥇
Also, it is passing in the tests and we still scaffolding the samples and all at the same way to it seems a quite improvement and we are face to fly 🚀

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86, mateusoliveira43

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [camilamacedo86]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment