🐛 fix: (helm/v1alpha1): env config should not be dependent on DeployImages

[monteiro-renato]

No description provided.

[k8s-ci-robot]

Hi @monteiro-renato. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[camilamacedo86]

Make sense 👍

/lgtm
/approve
/ok-to-test

Thank you 🥇

[monteiro-renato]

Updated the commit message now.

[camilamacedo86]

/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86, monteiro-renato

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [camilamacedo86]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[monteiro-renato]

I'm still relatively new to the codebase but shouldn't it be the deployimage plugin that should be responsible for checking that the project is using the helm plugin as the dist method and therefore update the values.yaml file with the needed env vars (and other relevant config)?

I need to play around with how plugin chaining works as my previous assumption seems to be wrong. I see that the helm plugin implementation is assuming that it will (potentially) be run after the deployimage.

[camilamacedo86]

Hi @monteiro-renato

My idea was: If someone use the plugin, then the code must be there otherwise not
But you are right. If someone customize it I think has no reason to accept that.