🌱 : Fix make remove-spaces for GNU system

[damsien]

This PR is motivated by this issue: #4327.

It is a fix about the make remove-spaces command that was only working on OS X and not GNU based system. It is because the behavior of the sed -i command is different between these two systems (see this stack exchange discussion).

• On OS X: sed -i ''
• On GNU: sed -i

So I added a check by using uname to use the sed -i in the correct way depending if we are on GNU based system or on OS X based system.

[k8s-ci-robot]

Hi @damsien. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[camilamacedo86]

I did not tested locally
I have mac.

But it passing in the CI
If that fails for me after we can check
All good

Thank you 🥇

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86, damsien

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [camilamacedo86]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[camilamacedo86]

/ok-to-test

[camilamacedo86]

@damsien

See that your solution broke things

So we will revert.
And next one I will ensure locally either before get merged

[damsien]

@camilamacedo86 I am sorry I didn't had the opportunity to test on a mac (I'm using arch linux). Hope that it didn't take you too long to revert

[camilamacedo86]

Hi @damsien

@camilamacedo86 I am sorry I didn't had the opportunity to test on a mac (I'm using arch linux). Hope that it didn't take you too long to revert

Not at all. It is all fine
It is my fault; I should test it out locally before approving
Just ping you for yu check so that you might want try out fix it again

[damsien]

Thanks! I'll create another PR when I have time to try to fix it again!