-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📖 Fix variable reference in docs #3641
📖 Fix variable reference in docs #3641
Conversation
Welcome @vaibhavkhurana2018! |
Hi @vaibhavkhurana2018. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Thanks! This was a copy pasta mistake on my part. I had the decoder field exported in my type in my project, but it was not exported for the podAnnotator type in this example 🤦♂️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/ok-to-test
/approved
Thank you lot for getting this one
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86, vaibhavkhurana2018 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fixes the reference of the struct var in the documentation as added in https://github.com/kubernetes-sigs/kubebuilder/pull/3613/files